Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 204553003: linux: use correct libgcrypt-config paths when cross-compiling (Closed)

Created:
6 years, 9 months ago by petarj
Modified:
6 years, 9 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

linux: use correct libgcrypt-config paths when cross-compiling Add a wrapper around libgcrypt-config to generate correct include and library paths when cross-compiling using a sysroot. BUG= Linux build with sysroot will fail TEST= Build Linux Chromium for MIPS Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258293

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
A build/linux/libgcrypt-config-wrapper View 1 chunk +17 lines, -0 lines 0 comments Download
M build/linux/system.gyp View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
petarj
After the recent CL [1] that started to treat linker warnings as errors on all ...
6 years, 9 months ago (2014-03-19 16:57:45 UTC) #1
brettw
I defer my review to piman, who understands this chroot stuff more than I.
6 years, 9 months ago (2014-03-19 22:04:35 UTC) #2
piman
lgtm
6 years, 9 months ago (2014-03-20 08:18:13 UTC) #3
petarj
The CQ bit was checked by petarj@mips.com
6 years, 9 months ago (2014-03-20 08:33:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petarj@mips.com/204553003/1
6 years, 9 months ago (2014-03-20 08:33:22 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-20 09:05:32 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel
6 years, 9 months ago (2014-03-20 09:05:33 UTC) #7
petarj
The CQ bit was checked by petarj@mips.com
6 years, 9 months ago (2014-03-20 09:53:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petarj@mips.com/204553003/1
6 years, 9 months ago (2014-03-20 09:54:12 UTC) #9
commit-bot: I haz the power
6 years, 9 months ago (2014-03-20 14:53:37 UTC) #10
Message was sent while issue was closed.
Change committed as 258293

Powered by Google App Engine
This is Rietveld 408576698