Issue 20455: Move implementation of comparisons with constant smis to use...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20455: Move implementation of comparisons with constant smis to use... (Closed)

Created:
11 years, 10 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
iposva, Kevin Millikin (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/experimental/toiger/

Visibility:
Public.

Description

Move implementation of comparisons with constant smis to use virtual frame constant results, not literal AST nodes. Drop smi check for comparisons with non-smi constants. Committed: http://code.google.com/p/v8/source/detail?r=1314

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -72 lines)			Patch
	M	src/codegen-ia32.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
	M	src/codegen-ia32.cc	View	1	3 chunks	+30 lines, -71 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Chromium)

11 years, 10 months ago (2009-02-19 10:35:00 UTC) #2

CodeGenerator::SmiComparison is dead code now so you should get rid of it.

Other than that, LGTM.

http://codereview.chromium.org/20455/diff/1/2
File src/codegen-ia32.cc (right):

http://codereview.chromium.org/20455/diff/1/2#newcode1338
Line 1338: ASSERT(left_side.is_valid());
These asserts aren't strictly necessary.  They'll never fail right now. 
ToRegister already asserts that the result is a register before returning.

Expand Messages | Collapse Messages