third_party/WebKit/Source/bindings/templates/interface.h - Issue 2045453002: Refactor WrapperTypeInfo.traceWrappers to WrapperTypeInfo.getHeader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/interface.h

Issue 2045453002: Refactor WrapperTypeInfo.traceWrappers to WrapperTypeInfo.getHeader (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use nicer name Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/WrapperTypeInfo.h ('k') | third_party/WebKit/Source/bindings/templates/interface.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/interface.h

diff --git a/third_party/WebKit/Source/bindings/templates/interface.h b/third_party/WebKit/Source/bindings/templates/interface.h

index a8b4c08e55c7f6ce015747d08fb4779472ca42a7..a822c75579a651582062338517e8e231e79e13b8 100644

--- a/third_party/WebKit/Source/bindings/templates/interface.h

+++ b/third_party/WebKit/Source/bindings/templates/interface.h

@@ -62,9 +62,9 @@ public:

{% else %}

{{exported}}static const WrapperTypeInfo wrapperTypeInfo;

{% endif %}

- static void traceWrappers(WrapperVisitor* visitor, ScriptWrappable* scriptWrappable)

+ static HeapObjectHeader* getHeapObjectHeader(ScriptWrappable* scriptWrappable)

{

- visitor->traceWrappers(scriptWrappable->toImpl<{{cpp_class}}>());

+ return HeapObjectHeader::fromPayload(scriptWrappable->toImpl<{{cpp_class}}>());

}

template<typename VisitorDispatcher>

static void trace(VisitorDispatcher visitor, ScriptWrappable* scriptWrappable)