third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h - Issue 2045453002: Refactor WrapperTypeInfo.traceWrappers to WrapperTypeInfo.getHeader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h

Issue 2045453002: Refactor WrapperTypeInfo.traceWrappers to WrapperTypeInfo.getHeader (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use nicer name Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/ActiveScriptWrappable.cpp ('k') | third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h

index 4d60467aac905abf60e2234d708602246d1b46b2..15ab14a313fbc9caa1cf708889fc082353710db9 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h

@@ -68,9 +68,9 @@ public:

void traceWrappers(const ScopedPersistent<v8::Value>*) const override;

private:

- bool markWrapperHeader(const ScriptWrappable*, const void*) const override;

- bool markWrapperHeader(const void* garbageCollected, const void*) const override;

- inline void addHeaderToUnmark(HeapObjectHeader*) const;

+ bool markWrapperHeader(HeapObjectHeader*) const;

+ bool markWrapperHeader(const ScriptWrappable*) const override;

+ bool markWrapperHeader(const void* garbageCollected) const override;

inline void traceWrappersFrom(std::pair<void*, void*> internalFields);

bool m_tracingInProgress = false;

/**