third_party/WebKit/Source/bindings/tests/results/core/V8DataView.h - Issue 2045453002: Refactor WrapperTypeInfo.traceWrappers to WrapperTypeInfo.getHeader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8DataView.h

Issue 2045453002: Refactor WrapperTypeInfo.traceWrappers to WrapperTypeInfo.getHeader (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/templates/interface.h ('K') | « third_party/WebKit/Source/bindings/tests/results/core/V8ArrayBufferView.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8DataView.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8DataView.h

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8DataView.h b/third_party/WebKit/Source/bindings/tests/results/core/V8DataView.h

index fcdc9b8eb9ecfe8a09956c0a3a6dbf07c259c15b..a3de3604a9033bb78be61e83adb726762ed53f3d 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8DataView.h

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8DataView.h

@@ -26,9 +26,9 @@ public:

CORE_EXPORT static TestDataView* toImpl(v8::Local<v8::Object> object);

CORE_EXPORT static TestDataView* toImplWithTypeCheck(v8::Isolate*, v8::Local<v8::Value>);

CORE_EXPORT static const WrapperTypeInfo wrapperTypeInfo;

- static void traceWrappers(WrapperVisitor* visitor, ScriptWrappable* scriptWrappable)

+ static HeapObjectHeader* getHeader(ScriptWrappable* scriptWrappable)

{

- visitor->traceWrappers(scriptWrappable->toImpl<TestDataView>());

+ return HeapObjectHeader::fromPayload(scriptWrappable->toImpl<TestDataView>());

}

template<typename VisitorDispatcher>

static void trace(VisitorDispatcher visitor, ScriptWrappable* scriptWrappable)