Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(650)

Issue 2045443002: Correcting the usage of returning Size object (Closed)

Created:
4 years, 6 months ago by AKV
Modified:
4 years, 6 months ago
Reviewers:
no sievers
CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, nona+watch_chromium.org, darin-cc_chromium.org, James Su
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correcting the usage of returning Size object For returning Size params, we don't have to create a Rect object. Instead returning Size value directly. BUG= Committed: https://crrev.com/eca7a4553090fbcb6f02720cc1028d248b98c3c3 Cr-Commit-Position: refs/heads/master@{#398240}

Patch Set 1 #

Patch Set 2 : Applied formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M content/browser/renderer_host/render_widget_host_view_android.cc View 1 2 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
AKV
PTAL!
4 years, 6 months ago (2016-06-06 12:25:09 UTC) #2
no sievers
lgtm
4 years, 6 months ago (2016-06-06 17:56:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045443002/20001
4 years, 6 months ago (2016-06-07 06:22:38 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-07 08:03:55 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 08:05:57 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eca7a4553090fbcb6f02720cc1028d248b98c3c3
Cr-Commit-Position: refs/heads/master@{#398240}

Powered by Google App Engine
This is Rietveld 408576698