Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issue 2045433002: exo: Fix surface origin offset. (Closed)

Created:
4 years, 6 months ago by reveman
Modified:
4 years, 6 months ago
Reviewers:
Daniele Castagna
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

exo: Fix surface origin offset. GetWindowBoundsInScreen() should never be used to determine the surface origin as it takes ancestor transforms into account. Surface origin should be relative to widget window bounds as they are not affected by transforms. BUG=549781 TEST=exo_unittests TBR=dcastagna@chromium.org Committed: https://crrev.com/9951be0bad4f2e88fbb2e8e1d17f43c395ffdad5 Cr-Commit-Position: refs/heads/master@{#397994}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M components/exo/shell_surface.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
reveman
4 years, 6 months ago (2016-06-06 08:36:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045433002/1
4 years, 6 months ago (2016-06-06 08:37:13 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-06 09:11:54 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-06 09:13:21 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9951be0bad4f2e88fbb2e8e1d17f43c395ffdad5
Cr-Commit-Position: refs/heads/master@{#397994}

Powered by Google App Engine
This is Rietveld 408576698