Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2045403002:
Worker: Add UMA to record an exit code of WorkerThread (Closed)
|
Created:
4 years, 6 months ago by nhiroki Modified:
4 years, 6 months ago CC:
chromium-reviews, falken, kinuko+worker_chromium.org, asvitkine+watch_chromium.org, blink-reviews, horo+watch_chromium.org, blink-worker-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionWorker: Add UMA to record an exit code of WorkerThread
BUG=616721
Committed: https://crrev.com/efb87570a17e42c56ed50b71a83f5861678ca2e9
Cr-Commit-Position: refs/heads/master@{#398824}
Patch Set 1 #
Total comments: 2
Patch Set 2 : rename the last enum #Patch Set 3 : rebase #Patch Set 4 : fix build failures #
Messages
Total messages: 29 (15 generated)
nhiroki@chromium.org changed reviewers: + kinuko@chromium.org
PTAL, thanks!
lgtm https://codereview.chromium.org/2045403002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/workers/WorkerThread.h (right): https://codereview.chromium.org/2045403002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/workers/WorkerThread.h:71: EnumMax, nit: max is a bit unclear, I started to prefer last (=last enum) or count (=last +1). (And slightly prefer last over count as it works better with switch/case warning)
Thank you! https://codereview.chromium.org/2045403002/diff/1/third_party/WebKit/Source/c... File third_party/WebKit/Source/core/workers/WorkerThread.h (right): https://codereview.chromium.org/2045403002/diff/1/third_party/WebKit/Source/c... third_party/WebKit/Source/core/workers/WorkerThread.h:71: EnumMax, On 2016/06/09 00:24:43, kinuko wrote: > nit: max is a bit unclear, I started to prefer last (=last enum) or count (=last > +1). (And slightly prefer last over count as it works better with switch/case > warning) Done.
Description was changed from ========== Worker: Add UMA to record an exit code of WorkerThread BUG=616721 ========== to ========== Worker: Add UMA to record an exit code of WorkerThread BUG=616721 ==========
nhiroki@chromium.org changed reviewers: + holte@chromium.org
+holte@, could you review histograms.xml? Thanks.
lgtm
The CQ bit was checked by nhiroki@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org Link to the patchset: https://codereview.chromium.org/2045403002/#ps20001 (title: "rename the last enum")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045403002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
The CQ bit was checked by nhiroki@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org, holte@chromium.org Link to the patchset: https://codereview.chromium.org/2045403002/#ps40001 (title: "rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045403002/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_android on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
The CQ bit was checked by nhiroki@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org, holte@chromium.org Link to the patchset: https://codereview.chromium.org/2045403002/#ps60001 (title: "fix build failures")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045403002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
The CQ bit was checked by nhiroki@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045403002/60001
Message was sent while issue was closed.
Description was changed from ========== Worker: Add UMA to record an exit code of WorkerThread BUG=616721 ========== to ========== Worker: Add UMA to record an exit code of WorkerThread BUG=616721 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Worker: Add UMA to record an exit code of WorkerThread BUG=616721 ========== to ========== Worker: Add UMA to record an exit code of WorkerThread BUG=616721 Committed: https://crrev.com/efb87570a17e42c56ed50b71a83f5861678ca2e9 Cr-Commit-Position: refs/heads/master@{#398824} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/efb87570a17e42c56ed50b71a83f5861678ca2e9 Cr-Commit-Position: refs/heads/master@{#398824} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
