content/browser/loader/navigation_url_loader.h - Issue 2045383002: PlzNavigate: detect when a ServiceWorker is present

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/loader/navigation_url_loader.h

Issue 2045383002: PlzNavigate: detect when a ServiceWorker is present (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/navigation_request.cc ('k') | content/browser/loader/navigation_url_loader.cc » ('j') | content/browser/web_contents/web_contents_impl_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/loader/navigation_url_loader.h

diff --git a/content/browser/loader/navigation_url_loader.h b/content/browser/loader/navigation_url_loader.h

index f7d3280f9b48fc0c34fd4779439bb2461f6e5cc0..632c84de51743ebf68ca9b3ae7ce45dd05805f52 100644

--- a/content/browser/loader/navigation_url_loader.h

+++ b/content/browser/loader/navigation_url_loader.h

@@ -15,7 +15,7 @@ namespace content {

class BrowserContext;

class NavigationURLLoaderDelegate;

class NavigationURLLoaderFactory;

-class ServiceWorkerNavigationHandle;

+class ServiceWorkerContextWrapper;

struct CommonNavigationParams;

struct NavigationRequestInfo;

@@ -36,7 +36,7 @@ class CONTENT_EXPORT NavigationURLLoader {

static std::unique_ptr<NavigationURLLoader> Create(

BrowserContext* browser_context,

std::unique_ptr<NavigationRequestInfo> request_info,

- ServiceWorkerNavigationHandle* service_worker_handle,

+ ServiceWorkerContextWrapper* service_worker_context_wrapper,

NavigationURLLoaderDelegate* delegate);

// For testing purposes; sets the factory for use in testing.