Routing IME Result Calls to the Correct RenderWidgetHost (Aura Only)

content/browser/renderer_host/text_input_manager.h

Index: content/browser/renderer_host/text_input_manager.h
diff --git a/content/browser/renderer_host/text_input_manager.h b/content/browser/renderer_host/text_input_manager.h
index 7dcbdfc2e82fcfc0078e75b3a8f52228d2193411..74b663def87d27033cb075d2007feaffb4fc8fb3 100644
--- a/content/browser/renderer_host/text_input_manager.h
+++ b/content/browser/renderer_host/text_input_manager.h
@@ -13,6 +13,7 @@
 
 namespace content {
 
+class RenderWidgetHostImpl;
 class RenderWidgetHostView;
 class RenderWidgetHostViewBase;
 class WebContents;
@@ -40,16 +41,28 @@ class CONTENT_EXPORT TextInputManager {
   TextInputManager();
   ~TextInputManager();
 
+  // ---------------------------------------------------------------------------
+  // The following methods give are used to obtain information about IME-related

[kenrb, 2016/06/13 19:37:47]

Nit: 'methods give are used'

[EhsanK, 2016/06/17 22:36:20]

Acknowledged.

+  // state for the active RWHV.
+
   // Returns the currently active view (i.e., the RWHV with a focused <input>
   // element), or nullptr if none exist. The |active_view_| cannot have a
   // |TextInputState.type| of ui::TEXT_INPUT_TYPE_NONE.
   RenderWidgetHostViewBase* GetActiveView() const;

[kenrb, 2016/06/13 19:37:47]

Is GetActiveView() still necessary? Looking at this now, since TextInputClient
messages go to the top RWHV and then are routed straight to the active
RenderWidgetHostImpl, I'm not clear on how GetActiveView() is intended to be
used (or, if only for unusual side cases, it the caller could call
GetActiveWidget()->GetView()).

[EhsanK, 2016/06/17 22:36:20]

It is not. I removed it. We store state for each view and hence I was returning
the active view here. But we do not actually need the view as all the IPC go
through the widget. The way it is now, we store state for each view but we
forward to widget.

 
+  // Returns the currently active widget, i.e., the RWH which is associated with
+  // |active_view_|.
+  RenderWidgetHostImpl* GetActiveWidget() const;
+
   // Returns the TextInputState corresponding to |active_view_|.
   // Users of this method should not hold on to the pointer as it might become
   // dangling if the TextInputManager or |active_view_| might go away.
   const TextInputState* GetTextInputState();
 
+  // ---------------------------------------------------------------------------
+  // The following methods are called by RWHVs on the tab to update their IME-
+  // related state.
+
   // Updates the TextInputState for |view|.
   void UpdateTextInputState(RenderWidgetHostViewBase* view,
                             const TextInputState& state);