@required support for super and redirecting cons (#26642).

@required support for super and redirecting cons (#26642).

R=brianwilkerson@google.com

Fixes: https://github.com/dart-lang/sdk/issues/26642
Committed: https://github.com/dart-lang/sdk/commit/435e38ab7778de3c5469b7149e738e649de7ade8

[pquitslund, 2016-06-08 16:45:20]

pquitslund@google.com changed reviewers:
+ brianwilkerson@google.com

[pquitslund, 2016-06-08 16:45:20]

Please let me know if you think we need to be testing more variations...

Thanks!

[Brian Wilkerson, 2016-06-08 17:06:31]

I suspect we also need a visit method for FunctionExpressionInvocation, and I
think the following test case will catch it:

import 'package:meta/meta.dart';

String test(C c) {
  return c.m()();
}
typedef String F({@required String x});
class C {
  F m() => ({@required String x}) => null;
}

[pquitslund, 2016-06-08 17:44:30]

On 2016/06/08 17:06:31, Brian Wilkerson wrote:
> I suspect we also need a visit method for FunctionExpressionInvocation, and I
> think the following test case will catch it:
> 
> import 'package:meta/meta.dart';
> 
> String test(C c) {
>   return c.m()();
> }
> typedef String F({@required String x});
> class C {
>   F m() => ({@required String x}) => null;
> }

Great catch!

Updated.  PTAL.

[Brian Wilkerson, 2016-06-08 18:17:58]

lgtm

[pquitslund, 2016-06-08 18:19:49]

Description was changed from

==========
@required support for super and redirecting cons (#26642).

Fixes: https://github.com/dart-lang/sdk/issues/26642
==========

to

==========
@required support for super and redirecting cons (#26642).

R=brianwilkerson@google.com

Fixes: https://github.com/dart-lang/sdk/issues/26642
Committed:
https://github.com/dart-lang/sdk/commit/435e38ab7778de3c5469b7149e738e649de7ade8
==========

[pquitslund, 2016-06-08 18:19:51]

Committed patchset #2 (id:20001) manually as
435e38ab7778de3c5469b7149e738e649de7ade8 (presubmit successful).