Dev tools warning and console warning for document.write script blocking

third_party/WebKit/Source/core/loader/FrameFetchContext.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 58 matching lines @@
 #include "platform/network/ResourceTimingInfo.h"
 #include "platform/weborigin/SchemeRegistry.h"
 #include "platform/weborigin/SecurityPolicy.h"
 #include "public/platform/WebCachePolicy.h"
 #include "public/platform/WebFrameScheduler.h"
 
 #include <algorithm>
 
 namespace blink {
 
-namespace {
+void FrameFetchContext::emitWarningForDocWriteScripts(const String& url) const

[Nate Chapin, 2016/06/09 23:44:44]

Maybe take the a const Document& here and keep this and
shouldDisallowFetchForMainFrameScript() file-scope?

+{
+    String message = "A Parser-blocking, cross-origin script " + url + " is invoked via document.write. This may get blocked by the browser in slow connections. It is recommended to invoke this script asynchronously.";
+    addConsoleMessage(message, WarningMessageLevel);

[Nate Chapin, 2016/06/09 23:44:44]

Call frame()->document()->addConsoleMessage() directly here? The overloaded
addConsoleMessage() helper doesn't seem worthwhile.

[shivanisha, 2016/06/10 14:41:01]

Sounds good. Made these changes.

+    WTFLogAlways("%s", message.utf8().data());
+}
 
-bool shouldDisallowFetchForMainFrameScript(const ResourceRequest& request, FetchRequest::DeferOption defer, const Document& document)
+bool FrameFetchContext::shouldDisallowFetchForMainFrameScript(const ResourceRequest& request, FetchRequest::DeferOption defer) const
 {
     // Only scripts inserted via document.write are candidates for having their
     // fetch disallowed.
-    if (!document.isInDocumentWrite())
+    if (!m_document->isInDocumentWrite())
         return false;
 
-    if (!document.settings())
+    if (!m_document->settings())
         return false;
 
-    if (!document.frame())
+    if (!m_document->frame())
         return false;
 
     // Only block synchronously loaded (parser blocking) scripts.
     if (defer != FetchRequest::NoDefer)
         return false;
 
     if (!request.url().protocolIsInHTTPFamily())
         return false;
 
     // Avoid blocking same origin scripts, as they may be used to render main
     // page content, whereas cross-origin scripts inserted via document.write
     // are likely to be third party content.
-    if (request.url().host() == document.getSecurityOrigin()->domain())
+    if (request.url().host() == m_document->getSecurityOrigin()->domain())
         return false;
 
     // Do not block scripts if it is a page reload. This is to enable pages to
     // recover if blocking of a script is leading to a page break and the user
     // reloads the page.
-    const FrameLoadType loadType = document.frame()->loader().loadType();
+    const FrameLoadType loadType = m_document->frame()->loader().loadType();
     const bool isReload = loadType == FrameLoadTypeReload || loadType == FrameLoadTypeReloadBypassingCache || loadType == FrameLoadTypeReloadMainResource;
     if (isReload) {
         // Recording this metric since an increase in number of reloads for pages
         // where a script was blocked could be indicative of a page break.
-        document.loader()->didObserveLoadingBehavior(WebLoadingBehaviorFlag::WebLoadingBehaviorDocumentWriteBlockReload);
+        m_document->loader()->didObserveLoadingBehavior(WebLoadingBehaviorFlag::WebLoadingBehaviorDocumentWriteBlockReload);
         return false;
     }
 
     // Add the metadata that this page has scripts inserted via document.write
     // that are eligible for blocking. Note that if there are multiple scripts
     // the flag will be conveyed to the browser process only once.
-    document.loader()->didObserveLoadingBehavior(WebLoadingBehaviorFlag::WebLoadingBehaviorDocumentWriteBlock);
+    m_document->loader()->didObserveLoadingBehavior(WebLoadingBehaviorFlag::WebLoadingBehaviorDocumentWriteBlock);
+
+    emitWarningForDocWriteScripts(request.url().getString());
 
     const bool isSlowConnection = networkStateNotifier().connectionType() == WebConnectionTypeCellular2G;
-    const bool disallowFetch = document.settings()->disallowFetchForDocWrittenScriptsInMainFrame() || (document.settings()->disallowFetchForDocWrittenScriptsInMainFrameOnSlowConnections() && isSlowConnection);
+    const bool disallowFetch = m_document->settings()->disallowFetchForDocWrittenScriptsInMainFrame() || (m_document->settings()->disallowFetchForDocWrittenScriptsInMainFrameOnSlowConnections() && isSlowConnection);
 
     return disallowFetch;
 }
 
-} // namespace
-
 FrameFetchContext::FrameFetchContext(DocumentLoader* loader, Document* document)
     : m_document(document)
     , m_documentLoader(loader)
 {
     ASSERT(frame());
 }
 
 FrameFetchContext::~FrameFetchContext()
 {
     m_document = nullptr;
@@ skipping 109 matching lines @@
                 return WebCachePolicy::BypassingCache;
             if (frameLoadType == FrameLoadTypeReload)
                 return WebCachePolicy::ValidatingCacheData;
         }
         return WebCachePolicy::UseProtocolCachePolicy;
     }
 
     // For users on slow connections, we want to avoid blocking the parser in
     // the main frame on script loads inserted via document.write, since it can
     // add significant delays before page content is displayed on the screen.
-    if (type == Resource::Script && isMainFrame() && m_document && shouldDisallowFetchForMainFrameScript(request, defer, *m_document))
+    if (type == Resource::Script && isMainFrame() && m_document && shouldDisallowFetchForMainFrameScript(request, defer))
         return WebCachePolicy::ReturnCacheDataDontLoad;
 
     if (request.isConditional())
         return WebCachePolicy::ValidatingCacheData;
 
     if (m_documentLoader && m_document && !m_document->loadEventFinished()) {
         // For POST requests, we mutate the main resource's cache policy to avoid form resubmission.
         // This policy should not be inherited by subresources.
         WebCachePolicy mainResourceCachePolicy = m_documentLoader->request().getCachePolicy();
         if (m_documentLoader->request().httpMethod() == "POST") {
@@ skipping 353 matching lines @@
         return false;
     info->setInitiatorType(frame()->deprecatedLocalOwner()->localName());
     return true;
 }
 
 void FrameFetchContext::sendImagePing(const KURL& url)
 {
     PingLoader::loadImage(frame(), url);
 }
 
+void FrameFetchContext::addConsoleMessage(const String& message, MessageLevel level) const
+{
+    if (frame()->document())
+        frame()->document()->addConsoleMessage(ConsoleMessage::create(JSMessageSource, level, message));
+}
+
 void FrameFetchContext::addConsoleMessage(const String& message) const
 {
     if (frame()->document())
         frame()->document()->addConsoleMessage(ConsoleMessage::create(JSMessageSource, ErrorMessageLevel, message));
 }
 
 SecurityOrigin* FrameFetchContext::getSecurityOrigin() const
 {
     return m_document ? m_document->getSecurityOrigin() : nullptr;
 }
@@ skipping 112 matching lines @@
 }
 
 DEFINE_TRACE(FrameFetchContext)
 {
     visitor->trace(m_document);
     visitor->trace(m_documentLoader);
     FetchContext::trace(visitor);
 }
 
 } // namespace blink