💼 Disable dx --incremental for libraries with only 1 .java file

Disable dx --incremental for libraries with only 1 .java file

The theory is that there is a bug for libraries with only a single .java
file.

BUG=617935, 616075
Committed: https://crrev.com/1cc61f54ccbd4048afc6f6f09d1bf98c8c1a48ab
Cr-Commit-Position: refs/heads/master@{#398782}

[agrieve, 2016-06-08 17:15:46]

Description was changed from

==========
Disable dx --incremental for libraries with only 1 .java file

The theory is that there is a bug for libraries with only a single .java
file.

BUG=617935
==========

to

==========
Disable dx --incremental for libraries with only 1 .java file

The theory is that there is a bug for libraries with only a single .java
file.

BUG=617935,616075
==========

[agrieve, 2016-06-08 17:15:47]

agrieve@chromium.org changed reviewers:
+ pkotwicz@chromium.org

[agrieve, 2016-06-08 17:15:53]

On 2016/06/08 17:15:47, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:pkotwicz@chromium.org

[agrieve, 2016-06-08 19:38:16]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[agrieve, 2016-06-08 19:38:38]

On 2016/06/08 17:15:53, agrieve wrote:
> On 2016/06/08 17:15:47, agrieve wrote:
> > mailto:agrieve@chromium.org changed reviewers:
> > + mailto:pkotwicz@chromium.org

[commit-bot: I haz the power, 2016-06-08 19:39:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2045313002/20001

[pkotwicz, 2016-06-08 20:11:42]

LGTM

I see no hackiness in this code 🙈

https://codereview.chromium.org/2045313002/diff/20001/build/android/gyp/dex.py
File build/android/gyp/dex.py (right):

https://codereview.chromium.org/2045313002/diff/20001/build/android/gyp/dex.p...
build/android/gyp/dex.py:119: # We've also been able to consistently reproduce
failure by adding an empty
"reproduce failure" -> "reproduce a failure"
"an empty lines" -> "an empty line"

[commit-bot: I haz the power, 2016-06-08 21:33:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-08 21:33:21]

Dry run: This issue passed the CQ dry run.

[agrieve, 2016-06-09 02:02:52]

https://codereview.chromium.org/2045313002/diff/20001/build/android/gyp/dex.py
File build/android/gyp/dex.py (right):

https://codereview.chromium.org/2045313002/diff/20001/build/android/gyp/dex.p...
build/android/gyp/dex.py:119: # We've also been able to consistently reproduce
failure by adding an empty
On 2016/06/08 20:11:42, pkotwicz wrote:
> "reproduce failure" -> "reproduce a failure"
> "an empty lines" -> "an empty line"

Done.

[agrieve, 2016-06-09 02:02:57]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2016-06-09 02:02:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkotwicz@chromium.org
Link to the patchset: https://codereview.chromium.org/2045313002/#ps40001
(title: "fix comments")

[commit-bot: I haz the power, 2016-06-09 02:03:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2045313002/40001

[commit-bot: I haz the power, 2016-06-09 04:33:54]

Description was changed from

==========
Disable dx --incremental for libraries with only 1 .java file

The theory is that there is a bug for libraries with only a single .java
file.

BUG=617935,616075
==========

to

==========
Disable dx --incremental for libraries with only 1 .java file

The theory is that there is a bug for libraries with only a single .java
file.

BUG=617935,616075
==========

[commit-bot: I haz the power, 2016-06-09 04:33:55]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-09 04:35:02]

Description was changed from

==========
Disable dx --incremental for libraries with only 1 .java file

The theory is that there is a bug for libraries with only a single .java
file.

BUG=617935,616075
==========

to

==========
Disable dx --incremental for libraries with only 1 .java file

The theory is that there is a bug for libraries with only a single .java
file.

BUG=617935,616075

Committed: https://crrev.com/1cc61f54ccbd4048afc6f6f09d1bf98c8c1a48ab
Cr-Commit-Position: refs/heads/master@{#398782}
==========

[commit-bot: I haz the power, 2016-06-09 04:35:03]

Patchset 3 (id:??) landed as
https://crrev.com/1cc61f54ccbd4048afc6f6f09d1bf98c8c1a48ab
Cr-Commit-Position: refs/heads/master@{#398782}