Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Unified Diff: profiler/stack_sampling_profiler_unittest.cc

Issue 2045303002: Update to Chromium //base at Chromium commit 3e81715e6d3a4324362635aea46ce1f1a163cca1. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/domokit/base@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « profiler/stack_sampling_profiler.cc ('k') | sync_socket_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: profiler/stack_sampling_profiler_unittest.cc
diff --git a/profiler/stack_sampling_profiler_unittest.cc b/profiler/stack_sampling_profiler_unittest.cc
index bcee51e33caedc17940ae641f4f0140310641a3a..33fa6234ac98319215b65d8eb4853a8e33d08dee 100644
--- a/profiler/stack_sampling_profiler_unittest.cc
+++ b/profiler/stack_sampling_profiler_unittest.cc
@@ -347,7 +347,7 @@ TEST(StackSamplingProfilerTest, MAYBE_StopDuringInterBurstInterval) {
EXPECT_EQ(1u, profiles[0].samples.size());
}
-// Checks that only completed call stack profiles are captured.
+// Checks that incomplete call stack profiles are captured.
#if defined(STACK_SAMPLING_PROFILER_SUPPORTED)
#define MAYBE_StopDuringInterSampleInterval StopDuringInterSampleInterval
#else
@@ -362,7 +362,8 @@ TEST(StackSamplingProfilerTest, MAYBE_StopDuringInterSampleInterval) {
std::vector<CallStackProfile> profiles;
CaptureProfiles(params, TimeDelta::FromMilliseconds(50), &profiles);
- EXPECT_TRUE(profiles.empty());
+ ASSERT_EQ(1u, profiles.size());
+ EXPECT_EQ(1u, profiles[0].samples.size());
}
// Checks that we can destroy the profiler while profiling.
« no previous file with comments | « profiler/stack_sampling_profiler.cc ('k') | sync_socket_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698