Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1710)

Unified Diff: debug/debugger_posix.cc

Issue 2045303002: Update to Chromium //base at Chromium commit 3e81715e6d3a4324362635aea46ce1f1a163cca1. (Closed) Base URL: https://chromium.googlesource.com/external/github.com/domokit/base@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android/scoped_java_ref.cc ('k') | file_version_info.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: debug/debugger_posix.cc
diff --git a/debug/debugger_posix.cc b/debug/debugger_posix.cc
index 8599571e34575fc4d2271cdfbb0ca0be451e181a..a2e804f2e63b36112b1a9369bd6811aa2270b620 100644
--- a/debug/debugger_posix.cc
+++ b/debug/debugger_posix.cc
@@ -35,6 +35,7 @@
#include <ostream>
#include "base/basictypes.h"
+#include "base/debug/alias.h"
#include "base/logging.h"
#include "base/memory/scoped_ptr.h"
#include "base/posix/eintr_wrapper.h"
@@ -237,6 +238,12 @@ void BreakDebugger() {
// NOTE: This code MUST be async-signal safe (it's used by in-process
// stack dumping signal handler). NO malloc or stdio is allowed here.
+ // Linker's ICF feature may merge this function with other functions with the
+ // same definition (e.g. any function whose sole job is to call abort()) and
+ // it may confuse the crash report processing system. http://crbug.com/508489
+ static int static_variable_to_make_this_function_unique = 0;
+ base::debug::Alias(&static_variable_to_make_this_function_unique);
+
DEBUG_BREAK();
#if defined(OS_ANDROID) && !defined(OFFICIAL_BUILD)
// For Android development we always build release (debug builds are
« no previous file with comments | « android/scoped_java_ref.cc ('k') | file_version_info.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698