Have VDA clients inform decoder of supported picture buffer formats

Have VDA clients inform decoder of supported picture buffer formats

Pepper plugins currently don't support NV12 picture buffers, so
add a list of supported formats to ensure they don't get sent NV12.

BUG=574292
Committed: https://crrev.com/d2a6d089046634d0ef4d799cfab05a8810da55b2
Cr-Commit-Position: refs/heads/master@{#400110}

[jbauman, 2016-06-09 23:00:15]

Description was changed from

==========
Have VDA clients inform decoder of supported picture buffer formats

BUG=
==========

to

==========
Have VDA clients inform decoder of supported picture buffer formats

Pepper plugins currently don't support NV12 picture buffers, so
add a list of supported formats to ensure they don't get sent NV12.

BUG=574292
==========

[jbauman, 2016-06-09 23:00:32]

jbauman@chromium.org changed reviewers:
+ dalecurtis@chromium.org, posciak@chromium.org

[DaleCurtis, 2016-06-09 23:38:03]

dalecurtis@chromium.org changed reviewers:
+ sandersd@chromium.org
- dalecurtis@chromium.org

[DaleCurtis, 2016-06-09 23:38:04]

=>sandersd

[sandersd (OOO until July 31), 2016-06-09 23:41:00]

lgtm, although neither VTVDA not AVDA actually have an actual pixel format for
their outputs. There are a few things conflated in that field but so far it
seems to be working.

Can we require that all clients support at least ARGB?

[jbauman, 2016-06-11 00:18:59]

jbauman@chromium.org changed reviewers:
+ raymes@chromium.org, wfh@chromium.org

[jbauman, 2016-06-11 00:19:00]

raymes: content/renderer/pepper OWNERS review
wfh: media/gpu/ipc/common OWNERS/security review.

Thanks.

[Pawel Osciak, 2016-06-13 07:57:31]

https://codereview.chromium.org/2045273005/diff/60001/media/video/video_decod...
File media/video/video_decode_accelerator.h (right):

https://codereview.chromium.org/2045273005/diff/60001/media/video/video_decod...
media/video/video_decode_accelerator.h:153: std::vector<VideoPixelFormat>
supported_output_formats{PIXEL_FORMAT_ARGB,
What would you think of making an empty list the default and treat that default
as "any", instead of "none" ?

[jbauman, 2016-06-13 23:11:48]

On 2016/06/13 07:57:31, Pawel Osciak wrote:
>
https://codereview.chromium.org/2045273005/diff/60001/media/video/video_decod...
> File media/video/video_decode_accelerator.h (right):
> 
>
https://codereview.chromium.org/2045273005/diff/60001/media/video/video_decod...
> media/video/video_decode_accelerator.h:153: std::vector<VideoPixelFormat>
> supported_output_formats{PIXEL_FORMAT_ARGB,
> What would you think of making an empty list the default and treat that
default
> as "any", instead of "none" ?

Ok, done.

[Will Harris, 2016-06-13 23:27:16]

media/gpu/ipc/common/media_param_traits_macros.h lgtm

[raymes, 2016-06-13 23:27:44]

raymes@chromium.org changed reviewers:
+ bbudge@chromium.org

[raymes, 2016-06-13 23:27:44]

defer to bbudge for content/renderer/pepper/pepper_video_decoder_host.cc

[bbudge, 2016-06-14 00:00:17]

Pepper lgtm

[Pawel Osciak, 2016-06-14 04:00:06]

On 2016/06/13 23:11:48, jbauman wrote:
> On 2016/06/13 07:57:31, Pawel Osciak wrote:
> >
>
https://codereview.chromium.org/2045273005/diff/60001/media/video/video_decod...
> > File media/video/video_decode_accelerator.h (right):
> > 
> >
>
https://codereview.chromium.org/2045273005/diff/60001/media/video/video_decod...
> > media/video/video_decode_accelerator.h:153: std::vector<VideoPixelFormat>
> > supported_output_formats{PIXEL_FORMAT_ARGB,
> > What would you think of making an empty list the default and treat that
> default
> > as "any", instead of "none" ?
> 
> Ok, done.

Thanks! Since this is addressing an issue with Pepper only, perhaps we should
only add anything to the config for Pepper, and not other clients, just to keep
the current defaults?

[jbauman, 2016-06-14 21:58:10]

PTAL.

On 2016/06/14 04:00:06, Pawel Osciak wrote:
> On 2016/06/13 23:11:48, jbauman wrote:
> > On 2016/06/13 07:57:31, Pawel Osciak wrote:
> > >
> >
>
https://codereview.chromium.org/2045273005/diff/60001/media/video/video_decod...
> > > File media/video/video_decode_accelerator.h (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/2045273005/diff/60001/media/video/video_decod...
> > > media/video/video_decode_accelerator.h:153: std::vector<VideoPixelFormat>
> > > supported_output_formats{PIXEL_FORMAT_ARGB,
> > > What would you think of making an empty list the default and treat that
> > default
> > > as "any", instead of "none" ?
> > 
> > Ok, done.
> 
> Thanks! Since this is addressing an issue with Pepper only, perhaps we should
> only add anything to the config for Pepper, and not other clients, just to
keep
> the current defaults?

Done.

[Pawel Osciak, 2016-06-16 05:41:37]

lgtm

[jbauman, 2016-06-16 06:41:11]

The CQ bit was checked by jbauman@chromium.org

[jbauman, 2016-06-16 06:41:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
sandersd@chromium.org, bbudge@chromium.org, wfh@chromium.org
Link to the patchset:
https://chromiumcodereview.appspot.com/2045273005/#ps100001 (title: " ")

[commit-bot: I haz the power, 2016-06-16 06:41:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2045273005/100001

[commit-bot: I haz the power, 2016-06-16 08:29:44]

Description was changed from

==========
Have VDA clients inform decoder of supported picture buffer formats

Pepper plugins currently don't support NV12 picture buffers, so
add a list of supported formats to ensure they don't get sent NV12.

BUG=574292
==========

to

==========
Have VDA clients inform decoder of supported picture buffer formats

Pepper plugins currently don't support NV12 picture buffers, so
add a list of supported formats to ensure they don't get sent NV12.

BUG=574292
==========

[commit-bot: I haz the power, 2016-06-16 08:29:46]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-06-16 08:31:17]

Description was changed from

==========
Have VDA clients inform decoder of supported picture buffer formats

Pepper plugins currently don't support NV12 picture buffers, so
add a list of supported formats to ensure they don't get sent NV12.

BUG=574292
==========

to

==========
Have VDA clients inform decoder of supported picture buffer formats

Pepper plugins currently don't support NV12 picture buffers, so
add a list of supported formats to ensure they don't get sent NV12.

BUG=574292

Committed: https://crrev.com/d2a6d089046634d0ef4d799cfab05a8810da55b2
Cr-Commit-Position: refs/heads/master@{#400110}
==========

[commit-bot: I haz the power, 2016-06-16 08:31:19]

Patchset 6 (id:??) landed as
https://crrev.com/d2a6d089046634d0ef4d799cfab05a8810da55b2
Cr-Commit-Position: refs/heads/master@{#400110}