src/x64/assembler-x64-inl.h - Issue 2045263002: [heap] Avoid the use of cells to point from code to new-space objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/assembler-x64-inl.h

Issue 2045263002: [heap] Avoid the use of cells to point from code to new-space objects. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: The IsSmi check in mov(HeapObject) lets some tests fail. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/assembler-x64-inl.h

diff --git a/src/x64/assembler-x64-inl.h b/src/x64/assembler-x64-inl.h

index 60acacd3bbb6417f8bc2b3d1a39edd839a285c19..a7256565f1d9b8e3803221de5ff41c6feb9a3b4a 100644

--- a/src/x64/assembler-x64-inl.h

+++ b/src/x64/assembler-x64-inl.h

@@ -410,6 +410,7 @@ void RelocInfo::set_target_object(Object* target,

target->IsHeapObject()) {

host()->GetHeap()->incremental_marking()->RecordWriteIntoCode(

host(), this, HeapObject::cast(target));

+ host()->GetHeap()->RecordWriteIntoCode(host(), this, target);

}

« no previous file with comments | « src/objects-inl.h ('k') | src/x64/macro-assembler-x64.h » ('j') | no next file with comments »