src/objects.h - Issue 2045263002: [heap] Avoid the use of cells to point from code to new-space objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.h

Issue 2045263002: [heap] Avoid the use of cells to point from code to new-space objects. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: The IsSmi check in mov(HeapObject) lets some tests fail. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects.h

diff --git a/src/objects.h b/src/objects.h

index a7aabe23e0f856b18734e09f3fe4f40c7b4b508d..694b93265a67b5d1042f42b74c3fbf8f9ecbb4c3 100644

--- a/src/objects.h

+++ b/src/objects.h

@@ -2853,7 +2853,8 @@ class ArrayList : public FixedArray {

inline void SetLength(int length);

inline Object* Get(int index);

inline Object** Slot(int index);

- inline void Set(int index, Object* obj);

+ inline void Set(int index, Object* obj,

+ WriteBarrierMode mode = UPDATE_WRITE_BARRIER);

inline void Clear(int index, Object* undefined);

bool IsFull();

DECLARE_CAST(ArrayList)

« no previous file with comments | « src/mips64/macro-assembler-mips64.cc ('k') | src/objects-debug.cc » ('j') | no next file with comments »