src/arm64/assembler-arm64.cc - Issue 2045263002: [heap] Avoid the use of cells to point from code to new-space objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm64/assembler-arm64.cc

Issue 2045263002: [heap] Avoid the use of cells to point from code to new-space objects. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: The IsSmi check in mov(HeapObject) lets some tests fail. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/arm64/assembler-arm64.cc

diff --git a/src/arm64/assembler-arm64.cc b/src/arm64/assembler-arm64.cc

index 7aea5bb135662bec839190ef6e5b0994503f660c..339f2de9055533c466328251bb73595b0b87c3d4 100644

--- a/src/arm64/assembler-arm64.cc

+++ b/src/arm64/assembler-arm64.cc

@@ -280,7 +280,6 @@ void Immediate::InitializeHandle(Handle<Object> handle) {

// Verify all Objects referred by code are NOT in new space.

Object* obj = *handle;

if (obj->IsHeapObject()) {

- DCHECK(!HeapObject::cast(obj)->GetHeap()->InNewSpace(obj));

value_ = reinterpret_cast<intptr_t>(handle.location());

rmode_ = RelocInfo::EMBEDDED_OBJECT;

} else {

« no previous file with comments | « src/arm/macro-assembler-arm.cc ('k') | src/arm64/assembler-arm64-inl.h » ('j') | no next file with comments »