Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(260)

Unified Diff: src/heap/heap.h

Issue 2045263002: [heap] Avoid the use of cells to point from code to new-space objects. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/heap/heap.h
diff --git a/src/heap/heap.h b/src/heap/heap.h
index c97c1889d1614b63298828745d6b360594bcbea5..8a41221ec33387817158540815abc51b44356f2f 100644
--- a/src/heap/heap.h
+++ b/src/heap/heap.h
@@ -189,6 +189,10 @@ using v8::MemoryPressureLevel;
V(FixedArray, detached_contexts, DetachedContexts) \
V(ArrayList, retained_maps, RetainedMaps) \
V(WeakHashTable, weak_object_to_code_table, WeakObjectToCodeTable) \
+ /* weak_code_to_new_space_ref_list is an arraylist of weak cells, where */ \
+ /* slots with even indices refer to the weak object, and the subsequent */ \
+ /* slots refer to the code with the reference to the weak object. */ \
+ V(ArrayList, weak_code_to_new_space_ref_list, WeakCodeToNewSpaceRefList) \
ulan 2016/06/08 14:37:00 Lets name it weak_new_space_object_to_code_list.
ahaas 2016/06/09 10:34:32 Done.
V(PropertyCell, array_protector, ArrayProtector) \
V(Cell, is_concat_spreadable_protector, IsConcatSpreadableProtector) \
V(PropertyCell, empty_property_cell, EmptyPropertyCell) \
@@ -838,6 +842,9 @@ class Heap {
return new_space_.IsAtMaximumCapacity() && maximum_size_scavenges_ == 0;
}
+ void RecordWeakCodeToNewSpaceReference(Handle<HeapObject> obj,
+ Handle<WeakCell> code);
+
void AddWeakObjectToCodeDependency(Handle<HeapObject> obj,
Handle<DependentCode> dep);

Powered by Google App Engine
This is Rietveld 408576698