[heap] Avoid the use of cells to point from code to new-space objects.

test/cctest/test-serialize.cc

 // Copyright 2007-2010 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 1843 matching lines @@
   byte* buffer = static_cast<byte*>(v8::base::OS::Allocate(
       Assembler::kMinimalBufferSize, &actual_size, true));
   CHECK(buffer);
   HandleScope handles(isolate);
 
   MacroAssembler assembler(isolate, buffer, static_cast<int>(actual_size),
                            v8::internal::CodeObjectRequired::kYes);
   assembler.enable_serializer();
   Handle<HeapNumber> number = isolate->factory()->NewHeapNumber(0.3);
   CHECK(isolate->heap()->InNewSpace(*number));
-  MacroAssembler* masm = &assembler;
-  masm->MoveHeapObject(rax, number);
-  masm->ret(0);
-  CodeDesc desc;
-  masm->GetCode(&desc);
-  Handle<Code> code = isolate->factory()->NewCode(
-      desc, Code::ComputeFlags(Code::FUNCTION), masm->CodeObject());
-  code->set_has_reloc_info_for_serialization(true);
-
+  Handle<Code> code;
+  {
+    MacroAssembler* masm = &assembler;
+    Handle<Cell> cell = isolate->factory()->NewCell(number);
+    masm->Move(rax, cell, RelocInfo::CELL);
+    masm->movp(rax, Operand(rax, 0));
+    masm->ret(0);
+    CodeDesc desc;
+    masm->GetCode(&desc);
+    code = isolate->factory()->NewCode(desc, Code::ComputeFlags(Code::FUNCTION),
+                                       masm->CodeObject());
+    code->set_has_reloc_info_for_serialization(true);
+  }
   RelocIterator rit1(*code, 1 << RelocInfo::CELL);
   CHECK_EQ(*number, rit1.rinfo()->target_cell()->value());
 
   Handle<String> source = isolate->factory()->empty_string();
   Handle<SharedFunctionInfo> sfi =
       isolate->factory()->NewSharedFunctionInfo(source, code, false);
   ScriptData* script_data = CodeSerializer::Serialize(isolate, sfi, source);
 
   Handle<SharedFunctionInfo> copy =
       CodeSerializer::Deserialize(isolate, script_data, source)
           .ToHandleChecked();
   RelocIterator rit2(copy->code(), 1 << RelocInfo::CELL);
   CHECK(rit2.rinfo()->target_cell()->IsCell());
   Handle<Cell> cell(rit2.rinfo()->target_cell());
   CHECK(cell->value()->IsHeapNumber());
   CHECK_EQ(0.3, HeapNumber::cast(cell->value())->value());
 
   delete script_data;
 }
 #endif  // V8_TARGET_ARCH_X64
 
 TEST(SerializationMemoryStats) {
   FLAG_profile_deserialization = true;
   FLAG_always_opt = false;
   v8::StartupData blob = v8::V8::CreateSnapshotDataBlob();
   delete[] blob.data;
 }