Chromium Code Reviews

Side by Side Diff: src/arm/assembler-arm.cc

Issue 2045263002: [heap] Avoid the use of cells to point from code to new-space objects. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Add comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff |
« no previous file with comments | « no previous file | src/arm/assembler-arm-inl.h » ('j') | src/heap/mark-compact.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 1994-2006 Sun Microsystems Inc. 1 // Copyright (c) 1994-2006 Sun Microsystems Inc.
2 // All Rights Reserved. 2 // All Rights Reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions 5 // modification, are permitted provided that the following conditions
6 // are met: 6 // are met:
7 // 7 //
8 // - Redistributions of source code must retain the above copyright notice, 8 // - Redistributions of source code must retain the above copyright notice,
9 // this list of conditions and the following disclaimer. 9 // this list of conditions and the following disclaimer.
10 // 10 //
(...skipping 268 matching lines...)
279 // ----------------------------------------------------------------------------- 279 // -----------------------------------------------------------------------------
280 // Implementation of Operand and MemOperand 280 // Implementation of Operand and MemOperand
281 // See assembler-arm-inl.h for inlined constructors 281 // See assembler-arm-inl.h for inlined constructors
282 282
283 Operand::Operand(Handle<Object> handle) { 283 Operand::Operand(Handle<Object> handle) {
284 AllowDeferredHandleDereference using_raw_address; 284 AllowDeferredHandleDereference using_raw_address;
285 rm_ = no_reg; 285 rm_ = no_reg;
286 // Verify all Objects referred by code are NOT in new space. 286 // Verify all Objects referred by code are NOT in new space.
287 Object* obj = *handle; 287 Object* obj = *handle;
288 if (obj->IsHeapObject()) { 288 if (obj->IsHeapObject()) {
289 DCHECK(!HeapObject::cast(obj)->GetHeap()->InNewSpace(obj));
290 imm32_ = reinterpret_cast<intptr_t>(handle.location()); 289 imm32_ = reinterpret_cast<intptr_t>(handle.location());
291 rmode_ = RelocInfo::EMBEDDED_OBJECT; 290 rmode_ = RelocInfo::EMBEDDED_OBJECT;
292 } else { 291 } else {
293 // no relocation needed 292 // no relocation needed
294 imm32_ = reinterpret_cast<intptr_t>(obj); 293 imm32_ = reinterpret_cast<intptr_t>(obj);
295 rmode_ = RelocInfo::NONE32; 294 rmode_ = RelocInfo::NONE32;
296 } 295 }
297 } 296 }
298 297
299 298
(...skipping 3975 matching lines...)
4275 DCHECK(is_uint12(offset)); 4274 DCHECK(is_uint12(offset));
4276 instr_at_put(pc, SetLdrRegisterImmediateOffset(instr, offset)); 4275 instr_at_put(pc, SetLdrRegisterImmediateOffset(instr, offset));
4277 } 4276 }
4278 } 4277 }
4279 4278
4280 4279
4281 } // namespace internal 4280 } // namespace internal
4282 } // namespace v8 4281 } // namespace v8
4283 4282
4284 #endif // V8_TARGET_ARCH_ARM 4283 #endif // V8_TARGET_ARCH_ARM
OLDNEW
« no previous file with comments | « no previous file | src/arm/assembler-arm-inl.h » ('j') | src/heap/mark-compact.cc » ('J')

Powered by Google App Engine