Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Side by Side Diff: src/objects-inl.h

Issue 2045263002: [heap] Avoid the use of cells to point from code to new-space objects. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: The IsSmi check in mov(HeapObject) lets some tests fail. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/objects-debug.cc ('k') | src/x64/assembler-x64-inl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Review notes: 5 // Review notes:
6 // 6 //
7 // - The use of macros in these inline functions may seem superfluous 7 // - The use of macros in these inline functions may seem superfluous
8 // but it is absolutely needed to make sure gcc generates optimal 8 // but it is absolutely needed to make sure gcc generates optimal
9 // code. gcc is not happy when attempting to inline too deep. 9 // code. gcc is not happy when attempting to inline too deep.
10 // 10 //
(...skipping 2446 matching lines...) Expand 10 before | Expand all | Expand 10 after
2457 2457
2458 Object* ArrayList::Get(int index) { 2458 Object* ArrayList::Get(int index) {
2459 return FixedArray::cast(this)->get(kFirstIndex + index); 2459 return FixedArray::cast(this)->get(kFirstIndex + index);
2460 } 2460 }
2461 2461
2462 2462
2463 Object** ArrayList::Slot(int index) { 2463 Object** ArrayList::Slot(int index) {
2464 return data_start() + kFirstIndex + index; 2464 return data_start() + kFirstIndex + index;
2465 } 2465 }
2466 2466
2467 2467 void ArrayList::Set(int index, Object* obj, WriteBarrierMode mode) {
2468 void ArrayList::Set(int index, Object* obj) { 2468 FixedArray::cast(this)->set(kFirstIndex + index, obj, mode);
2469 FixedArray::cast(this)->set(kFirstIndex + index, obj);
2470 } 2469 }
2471 2470
2472 2471
2473 void ArrayList::Clear(int index, Object* undefined) { 2472 void ArrayList::Clear(int index, Object* undefined) {
2474 DCHECK(undefined->IsUndefined(GetIsolate())); 2473 DCHECK(undefined->IsUndefined(GetIsolate()));
2475 FixedArray::cast(this) 2474 FixedArray::cast(this)
2476 ->set(kFirstIndex + index, undefined, SKIP_WRITE_BARRIER); 2475 ->set(kFirstIndex + index, undefined, SKIP_WRITE_BARRIER);
2477 } 2476 }
2478 2477
2479 2478
(...skipping 5429 matching lines...) Expand 10 before | Expand all | Expand 10 after
7909 #undef WRITE_INT64_FIELD 7908 #undef WRITE_INT64_FIELD
7910 #undef READ_BYTE_FIELD 7909 #undef READ_BYTE_FIELD
7911 #undef WRITE_BYTE_FIELD 7910 #undef WRITE_BYTE_FIELD
7912 #undef NOBARRIER_READ_BYTE_FIELD 7911 #undef NOBARRIER_READ_BYTE_FIELD
7913 #undef NOBARRIER_WRITE_BYTE_FIELD 7912 #undef NOBARRIER_WRITE_BYTE_FIELD
7914 7913
7915 } // namespace internal 7914 } // namespace internal
7916 } // namespace v8 7915 } // namespace v8
7917 7916
7918 #endif // V8_OBJECTS_INL_H_ 7917 #endif // V8_OBJECTS_INL_H_
OLDNEW
« no previous file with comments | « src/objects-debug.cc ('k') | src/x64/assembler-x64-inl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698