Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1763)

Issue 2045253008: Move CFI Linux CF bot to a real recipe (Closed)

Created:
4 years, 6 months ago by Nico
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke, krasin1
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Move CFI Linux CF bot to a real recipe The master.cfg didn't have the right annotator factory, so the existing recipe config was ignored and the bot was converted to an autogen config a few months later. Fix the annotator factory, and also add some missing stuff to the recipe. BUG=607729, 568384 Committed: https://chromium.googlesource.com/chromium/tools/build/+/d2156b04fc216cb07a35a1aa11e081373468acdd

Patch Set 1 #

Patch Set 2 : less #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -255 lines) Patch
M masters/master.chromium.fyi/master.cfg View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium/config.py View 1 1 chunk +0 lines, -1 line 0 comments Download
M scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py View 1 1 chunk +7 lines, -4 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_CFI_Linux_CF.json View 3 chunks +87 lines, -16 lines 0 comments Download
M scripts/slave/recipes/chromium.fyi.misc_block.recipe_autogen.py View 2 chunks +0 lines, -76 lines 1 comment Download
D scripts/slave/recipes/chromium.fyi.misc_block.recipe_autogen.expected/CFI_Linux_CF.json View 1 chunk +0 lines, -157 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Nico
https://codereview.chromium.org/2045253008/diff/20001/scripts/slave/recipes/chromium.fyi.misc_block.recipe_autogen.py File scripts/slave/recipes/chromium.fyi.misc_block.recipe_autogen.py (left): https://codereview.chromium.org/2045253008/diff/20001/scripts/slave/recipes/chromium.fyi.misc_block.recipe_autogen.py#oldcode96 scripts/slave/recipes/chromium.fyi.misc_block.recipe_autogen.py:96: # gclient runhooks wrapper step this function is what ...
4 years, 6 months ago (2016-06-09 20:36:55 UTC) #2
Dirk Pranke
lgtm
4 years, 6 months ago (2016-06-09 20:46:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045253008/20001
4 years, 6 months ago (2016-06-09 20:51:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045253008/20001
4 years, 6 months ago (2016-06-09 20:52:42 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 20:55:40 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/d2156b04fc216cb07a35...

Powered by Google App Engine
This is Rietveld 408576698