Reland: git_cache.py: Clobber git repos if the config is corrupt

Reland: git_cache.py: Clobber git repos if the config is corrupt

Reland of: https://codereview.chromium.org/2049463003/

See https://build.chromium.org/p/tryserver.chromium.win/builders/win10_chromium_x64_rel_ng_exp/builds/1801/steps/bot_update/logs/stdio
[Mirror] https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.win%2Fwin10_chromium_x64_rel_ng_exp%2F1801%2F%2B%2Frecipes%2Fsteps%2Fbot_update%2F0%2Fstdout

Sometimes repos become corrupt and bot_update fails spectacularly.  This usually happens due to the process being interrupted during a fetch. Git
cache should be able to recover from this by clobbering.

BUG=

Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/dcd840489db879b13096f061915a1e84e8a714e9

[Ryan Tseng, 2016-06-08 21:56:46]

The CQ bit was checked by hinoka@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-08 21:56:54]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2045243004/1

[Ryan Tseng, 2016-06-08 21:57:13]

hinoka@google.com changed reviewers:
+ phajdan.jr@chromium.org, sergeyberezin@chromium.org

[commit-bot: I haz the power, 2016-06-08 22:00:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-08 22:00:25]

Dry run: This issue passed the CQ dry run.

[Sergey Berezin, 2016-06-08 23:21:58]

LGTM.

Given yesterday's outage, is it possible / reasonable to attempt to reproduce a
diamond dependency problem locally and make sure we don't corrupt another 30
bots?

[chromium-reviews, 2016-06-09 00:34:20]

I did run the exact configuration locally with success (src.git checkout,
with cache_dir).  I have confidence this would work, but unfortunately
without running this several thousand times it's impossible to tell if this
race condition would pop up (esp. if it's dependent on individual machine
performance profiles).

But yeah, that configuration has been verified locally.

On Wed, Jun 8, 2016 at 4:21 PM, <sergeyberezin@chromium.org> wrote:

> LGTM.
>
> Given yesterday's outage, is it possible / reasonable to attempt to
> reproduce a
> diamond dependency problem locally and make sure we don't corrupt another
> 30
> bots?
>
> https://codereview.chromium.org/2045243004/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Sergey Berezin, 2016-06-09 00:47:39]

Awesome, thanks! Let's land it.

On 2016/06/09 00:34:20, chromium-reviews wrote:
> I did run the exact configuration locally with success (src.git checkout,
> with cache_dir).  I have confidence this would work, but unfortunately
> without running this several thousand times it's impossible to tell if this
> race condition would pop up (esp. if it's dependent on individual machine
> performance profiles).
> 
> But yeah, that configuration has been verified locally.
> 
> On Wed, Jun 8, 2016 at 4:21 PM, <mailto:sergeyberezin@chromium.org> wrote:
> 
> > LGTM.
> >
> > Given yesterday's outage, is it possible / reasonable to attempt to
> > reproduce a
> > diamond dependency problem locally and make sure we don't corrupt another
> > 30
> > bots?
> >
> > https://codereview.chromium.org/2045243004/
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[Ryan Tseng, 2016-06-09 01:32:47]

The CQ bit was checked by hinoka@google.com

[commit-bot: I haz the power, 2016-06-09 01:32:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2045243004/1

[commit-bot: I haz the power, 2016-06-09 01:39:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-09 01:39:21]

Try jobs failed on following builders:
  Depot Tools Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubm...)

[Paweł Hajdan Jr., 2016-06-09 10:26:08]

LGTM

[hinoka, 2016-06-09 21:22:36]

The CQ bit was checked by hinoka@chromium.org

[commit-bot: I haz the power, 2016-06-09 21:22:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2045243004/1

[commit-bot: I haz the power, 2016-06-09 21:26:20]

Description was changed from

==========
Reland: git_cache.py: Clobber git repos if the config is corrupt

Reland of: https://codereview.chromium.org/2049463003/

See
https://build.chromium.org/p/tryserver.chromium.win/builders/win10_chromium_x...
[Mirror]
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.win%2...

Sometimes repos become corrupt and bot_update fails spectacularly.  This usually
happens due to the process being interrupted during a fetch. Git
cache should be able to recover from this by clobbering.

BUG=
==========

to

==========
Reland: git_cache.py: Clobber git repos if the config is corrupt

Reland of: https://codereview.chromium.org/2049463003/

See
https://build.chromium.org/p/tryserver.chromium.win/builders/win10_chromium_x...
[Mirror]
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Ftryserver.chromium.win%2...

Sometimes repos become corrupt and bot_update fails spectacularly.  This usually
happens due to the process being interrupted during a fetch. Git
cache should be able to recover from this by clobbering.

BUG=

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/dcd840489db879...
==========

[commit-bot: I haz the power, 2016-06-09 21:26:21]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/dcd840489db879...