Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 204523002: Fix for undefined base::FilePath in chrome_extensions_api_client.cc (Closed)

Created:
6 years, 9 months ago by Tomasz Moniuszko
Modified:
6 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix for undefined base::FilePath in chrome_extensions_api_client.cc There was a compilation error when ENABLE_CONFIGURATION_POLICY was not defined. If ENABLE_CONFIGURATION_POLICY was defined then base/files/file_path.h was included from chrome/browser/extensions/api/storage/managed_value_store_cache.h BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=258037

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/extensions/api/chrome_extensions_api_client.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Tomasz Moniuszko
6 years, 9 months ago (2014-03-19 14:18:55 UTC) #1
Marijn Kruisselbrink
lgtm
6 years, 9 months ago (2014-03-19 14:49:41 UTC) #2
Tomasz Moniuszko
The CQ bit was checked by tmoniuszko@opera.com
6 years, 9 months ago (2014-03-19 15:05:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tmoniuszko@opera.com/204523002/1
6 years, 9 months ago (2014-03-19 15:06:31 UTC) #4
commit-bot: I haz the power
6 years, 9 months ago (2014-03-19 18:03:48 UTC) #5
Message was sent while issue was closed.
Change committed as 258037

Powered by Google App Engine
This is Rietveld 408576698