Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2045203004:
Use absolute namespace references in //base/logging.h macros (Closed)
|
Created:
4 years, 6 months ago by tsniatowski Modified:
4 years, 5 months ago Reviewers:
Mark Mentovai CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUse absolute namespace references in //base/logging.h macros
Macros can be used in various namespace contexts, and macros that expand
to "logging::Something" can end up choosing some_namespace::logging
if used in a context wher ethere exists a nested namespace logging with
a conflicting name like LogMessage. It's fixable by using "::logging::"
instead of "logging::" in the macros.
No examples of such issues in chrome, but this can help downstream and
seems a good thing to do consistently.
BUG=
Committed: https://crrev.com/612550fd30ada9255df285534eef179c9301b398
Cr-Commit-Position: refs/heads/master@{#406910}
Patch Set 1 #
Messages
Total messages: 17 (8 generated)
Description was changed from ========== Use absolute namespace references in //base/logging.h macros Macros can be used in various namespace contexts, and macros that expand to "logging::Something" can end up choosing some_namespace::logging if used in a context wher ethere exists a nested namespace logging with a conflicting name like LogMessage. It's fixable by using "::logging::" instead of "logging::" in the macros. No examples of such issues in chrome, but this can help downstream and seems a good thing to do consistently. BUG= ========== to ========== Use absolute namespace references in //base/logging.h macros Macros can be used in various namespace contexts, and macros that expand to "logging::Something" can end up choosing some_namespace::logging if used in a context wher ethere exists a nested namespace logging with a conflicting name like LogMessage. It's fixable by using "::logging::" instead of "logging::" in the macros. No examples of such issues in chrome, but this can help downstream and seems a good thing to do consistently. BUG= ==========
tsniatowski@opera.com changed reviewers: + mark@chromium.org
tsniatowski@opera.com changed reviewers: + jam@chromium.org - mark@chromium.org
PTAL
please pick an owner from base/owners
tsniatowski@opera.com changed reviewers: + thakis@chromium.org - jam@chromium.org
On 2016/06/08 16:11:11, jam wrote: > please pick an owner from base/owners done (I blame git-cl owners). Nico: PTAL
On 2016/06/09 05:17:51, tsniatowski wrote: > On 2016/06/08 16:11:11, jam wrote: > > please pick an owner from base/owners > > done (I blame git-cl owners). > > Nico: PTAL Ping
tsniatowski@opera.com changed reviewers: + mark@chromium.org - thakis@chromium.org
On 2016/06/23 05:40:14, tsniatowski wrote: > On 2016/06/09 05:17:51, tsniatowski wrote: > > On 2016/06/08 16:11:11, jam wrote: > > > please pick an owner from base/owners > > > > done (I blame git-cl owners). > > > > Nico: PTAL > > Ping @mark: PTAL
LGTM. Good call.
The CQ bit was checked by tsniatowski@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Use absolute namespace references in //base/logging.h macros Macros can be used in various namespace contexts, and macros that expand to "logging::Something" can end up choosing some_namespace::logging if used in a context wher ethere exists a nested namespace logging with a conflicting name like LogMessage. It's fixable by using "::logging::" instead of "logging::" in the macros. No examples of such issues in chrome, but this can help downstream and seems a good thing to do consistently. BUG= ========== to ========== Use absolute namespace references in //base/logging.h macros Macros can be used in various namespace contexts, and macros that expand to "logging::Something" can end up choosing some_namespace::logging if used in a context wher ethere exists a nested namespace logging with a conflicting name like LogMessage. It's fixable by using "::logging::" instead of "logging::" in the macros. No examples of such issues in chrome, but this can help downstream and seems a good thing to do consistently. BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Use absolute namespace references in //base/logging.h macros Macros can be used in various namespace contexts, and macros that expand to "logging::Something" can end up choosing some_namespace::logging if used in a context wher ethere exists a nested namespace logging with a conflicting name like LogMessage. It's fixable by using "::logging::" instead of "logging::" in the macros. No examples of such issues in chrome, but this can help downstream and seems a good thing to do consistently. BUG= ========== to ========== Use absolute namespace references in //base/logging.h macros Macros can be used in various namespace contexts, and macros that expand to "logging::Something" can end up choosing some_namespace::logging if used in a context wher ethere exists a nested namespace logging with a conflicting name like LogMessage. It's fixable by using "::logging::" instead of "logging::" in the macros. No examples of such issues in chrome, but this can help downstream and seems a good thing to do consistently. BUG= Committed: https://crrev.com/612550fd30ada9255df285534eef179c9301b398 Cr-Commit-Position: refs/heads/master@{#406910} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/612550fd30ada9255df285534eef179c9301b398 Cr-Commit-Position: refs/heads/master@{#406910} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
