Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2045193002: [runtime] Deprecate RUNTIME_ASSERT from object ops. (Closed)

Created:
4 years, 6 months ago by Michael Starzinger
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Deprecate RUNTIME_ASSERT from object ops. This removes explicit uses of the RUNTIME_ASSERT macro from some runtime methods. The implicit ones in CONVERT_FOO_ARG_CHECKED will be addressed in a separate CL for all runtime modules at once. R=bmeurer@chromium.org BUG=v8:5066 Committed: https://crrev.com/206cf398517f8b9305d96b7638ae3146cf77afa2 Cr-Commit-Position: refs/heads/master@{#36852}

Patch Set 1 #

Patch Set 2 : Remove obsolete tests. #

Patch Set 3 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -137 lines) Patch
M src/runtime/runtime-collections.cc View 9 chunks +16 lines, -16 lines 0 comments Download
M src/runtime/runtime-compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-function.cc View 5 chunks +5 lines, -6 lines 0 comments Download
M src/runtime/runtime-generator.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M src/runtime/runtime-object.cc View 8 chunks +14 lines, -15 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 2 chunks +2 lines, -12 lines 0 comments Download
M src/runtime/runtime-typedarray.cc View 7 chunks +21 lines, -21 lines 0 comments Download
D test/mjsunit/regress/regress-403292.js View 1 1 chunk +0 lines, -55 lines 0 comments Download
D test/mjsunit/regress/regress-crbug-498142.js View 1 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Michael Starzinger
4 years, 6 months ago (2016-06-09 10:29:19 UTC) #3
Benedikt Meurer
lgtm
4 years, 6 months ago (2016-06-09 11:01:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045193002/40001
4 years, 6 months ago (2016-06-09 11:20:32 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-09 11:22:12 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 11:22:32 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/206cf398517f8b9305d96b7638ae3146cf77afa2
Cr-Commit-Position: refs/heads/master@{#36852}

Powered by Google App Engine
This is Rietveld 408576698