Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 2045093002: In DevicePermissionsDialogView disable Connect button if no device selected (Closed)

Created:
4 years, 6 months ago by juncai
Modified:
4 years, 6 months ago
Reviewers:
Finnur
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, tfarina, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

In DevicePermissionsDialogView disable Connect button if no device selected When no device selected in the dialog, the "Connect" button needs to be disabled. BUG=613596 Committed: https://crrev.com/934705e07d1a26be6c3e67c413c99cf888b93a02 Cr-Commit-Position: refs/heads/master@{#398602}

Patch Set 1 : in DevicePermissionsDialogView disable Connect button if no device selected #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -1 line) Patch
M chrome/browser/ui/views/extensions/device_permissions_dialog_view.h View 3 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/device_permissions_dialog_view.cc View 4 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
juncai
Please take a look.
4 years, 6 months ago (2016-06-08 00:14:51 UTC) #2
Finnur
LGTM
4 years, 6 months ago (2016-06-08 10:34:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045093002/1
4 years, 6 months ago (2016-06-08 16:25:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 16:59:07 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 17:00:52 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/934705e07d1a26be6c3e67c413c99cf888b93a02
Cr-Commit-Position: refs/heads/master@{#398602}

Powered by Google App Engine
This is Rietveld 408576698