Remove implicit CFX_CountedRef::operator T*()

Remove implicit CFX_CountedRef::operator T*()

Explicitly invoke GetObject() method instead.  This avoids
having code where it looks like non-pointers are assigned to
pointers but works due to the cast operator.

Committed: https://pdfium.googlesource.com/pdfium/+/7d2a8d966643ebc77c1aa0f0c53a0ffd2d681c4c

[Tom Sepez, 2016-06-08 18:32:42]

tsepez@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Tom Sepez, 2016-06-08 18:32:43]

Dan, pls. review.

[dsinclair, 2016-06-08 18:45:54]

lgtm

https://codereview.chromium.org/2045083003/diff/20001/core/fxcrt/include/fx_b...
File core/fxcrt/include/fx_basic.h (right):

https://codereview.chromium.org/2045083003/diff/20001/core/fxcrt/include/fx_b...
core/fxcrt/include/fx_basic.h:688: bool NotNull() const { return !IsNull(); }
Can we have a followup to remove this? Seems just as easy to say !IsNull then
NotNull()

[Tom Sepez, 2016-06-08 18:49:59]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-06-08 18:50:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2045083003/20001

[commit-bot: I haz the power, 2016-06-08 18:51:26]

Description was changed from

==========
Remove implicit CFX_CountedRef::operator T*()

Explicitly invoke GetObject() method instead.  This avoids
having code where it looks like non-pointers are assigned to
pointers but works due to the cast operator.
==========

to

==========
Remove implicit CFX_CountedRef::operator T*()

Explicitly invoke GetObject() method instead.  This avoids
having code where it looks like non-pointers are assigned to
pointers but works due to the cast operator.

Committed:
https://pdfium.googlesource.com/pdfium/+/7d2a8d966643ebc77c1aa0f0c53a0ffd2d68...
==========

[commit-bot: I haz the power, 2016-06-08 18:51:27]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/7d2a8d966643ebc77c1aa0f0c53a0ffd2d68...