Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Unified Diff: blimp/engine/common/blimp_browser_context_unittest.cc

Issue 2045073002: Export stability metrics to UMA from Blimp engine (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/engine/common/blimp_browser_context.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/engine/common/blimp_browser_context_unittest.cc
diff --git a/blimp/engine/common/blimp_browser_context_unittest.cc b/blimp/engine/common/blimp_browser_context_unittest.cc
index f32c7f17b6ea0e42bdb8f7fd8e36d712037e78c0..222f35fc4ffbd76acbb52ceca364779ece299a79 100644
--- a/blimp/engine/common/blimp_browser_context_unittest.cc
+++ b/blimp/engine/common/blimp_browser_context_unittest.cc
@@ -7,6 +7,7 @@
#include "base/metrics/user_metrics.h"
#include "base/threading/thread_task_runner_handle.h"
#include "components/metrics/metrics_service.h"
+#include "content/public/browser/notification_service.h"
#include "content/public/test/test_browser_thread_bundle.h"
#include "net/log/net_log.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -20,7 +21,11 @@ class BlimpBrowserContextTest : public testing::Test {
protected:
void SetUp() override {
+ // Set up NotificationService for StabilityMetricsHelper to use.
+ notification_service_.reset(content::NotificationService::Create());
+
base::SetRecordActionTaskRunner(base::ThreadTaskRunnerHandle::Get());
+
// Create BlimpBrowserContext.
browser_context_.reset(new BlimpBrowserContext(false /* off_the_record */,
&net_log_));
@@ -35,6 +40,7 @@ class BlimpBrowserContextTest : public testing::Test {
private:
content::TestBrowserThreadBundle thread_bundle_;
+ std::unique_ptr<content::NotificationService> notification_service_;
net::NetLog net_log_;
std::unique_ptr<BlimpBrowserContext> browser_context_;
« no previous file with comments | « blimp/engine/common/blimp_browser_context.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698