[New go generator] Implement declaring unions.

[New go generator] Implement non-nested unions.

R=vardhan@google.com, vardhan

Committed: https://chromium.googlesource.com/external/mojo/+/9ec80421c03ee885e8dcdf153d8003ced5acd0bc

[vardhan, 2016-06-08 20:45:47]

https://codereview.chromium.org/2045063002/diff/1/mojom/generators/go/transla...
File mojom/generators/go/translator/translator.go (right):

https://codereview.chromium.org/2045063002/diff/1/mojom/generators/go/transla...
mojom/generators/go/translator/translator.go:106: panic(fmt.Sprintf("%s is not a
union.", userDefinedTypeShortName(u)))
use log.Panicf() ? I guess you're looking to panic() vs. Fatal() so that you can
get a stack trace?

(seems like `log` is what the go libraries use, so I'm going that route with the
C generator)

https://codereview.chromium.org/2045063002/diff/20001/mojom/generators/go/tem...
File mojom/generators/go/templates/templates.go (right):

https://codereview.chromium.org/2045063002/diff/20001/mojom/generators/go/tem...
mojom/generators/go/templates/templates.go:76: {{- range $union :=
$fileTmpl.Imports}}
hm.. did you mean $fileTmpl.Unions?

and below this line, did you mean $union instead of $struct?

[azani, 2016-06-08 23:16:56]

Description was changed from

==========
[New go generator] Implement declaring unions.

R=vardhan
==========

to

==========
[New go generator] Implement non-nested unions.

R=vardhan
==========

[azani, 2016-06-08 23:51:49]

ptal

https://codereview.chromium.org/2045063002/diff/1/mojom/generators/go/transla...
File mojom/generators/go/translator/translator.go (right):

https://codereview.chromium.org/2045063002/diff/1/mojom/generators/go/transla...
mojom/generators/go/translator/translator.go:106: panic(fmt.Sprintf("%s is not a
union.", userDefinedTypeShortName(u)))
On 2016/06/08 20:45:47, vardhan wrote:
> use log.Panicf() ? I guess you're looking to panic() vs. Fatal() so that you
can
> get a stack trace?
> 
> (seems like `log` is what the go libraries use, so I'm going that route with
the
> C generator)

Done.

https://codereview.chromium.org/2045063002/diff/20001/mojom/generators/go/tem...
File mojom/generators/go/templates/templates.go (right):

https://codereview.chromium.org/2045063002/diff/20001/mojom/generators/go/tem...
mojom/generators/go/templates/templates.go:76: {{- range $union :=
$fileTmpl.Imports}}
On 2016/06/08 20:45:47, vardhan wrote:
> hm.. did you mean $fileTmpl.Unions?
> 
> and below this line, did you mean $union instead of $struct?

Done.

[vardhan, 2016-06-09 00:05:36]

there seems to be a lot more new code in the latest patchset than the previous
one.  could you reply back with an explanation of what you've added so that I
have some context when i'm reviewing?

[azani, 2016-06-13 20:27:22]

Sorry, I screwed that up. Anyways, the previous patchset only declared unions.
The new one also serializes them.

[vardhan, 2016-06-14 16:50:31]

lgtm

[azani, 2016-06-14 17:22:28]

Description was changed from

==========
[New go generator] Implement non-nested unions.

R=vardhan
==========

to

==========
[New go generator] Implement non-nested unions.

R=vardhan@google.com, vardhan

Committed:
https://chromium.googlesource.com/external/mojo/+/9ec80421c03ee885e8dcdf153d8...
==========

[azani, 2016-06-14 17:22:31]

Committed patchset #4 (id:60001) manually as
9ec80421c03ee885e8dcdf153d8003ced5acd0bc (presubmit successful).