Chromium Code Reviews| Index: scripts/slave/recipe_modules/auto_bisect/api.py |
| diff --git a/scripts/slave/recipe_modules/auto_bisect/api.py b/scripts/slave/recipe_modules/auto_bisect/api.py |
| index 50a988604643b054915ade4a23ffb5d5fbefc467..2717165e778be76817848be3567cdb45298d6b1c 100644 |
| --- a/scripts/slave/recipe_modules/auto_bisect/api.py |
| +++ b/scripts/slave/recipe_modules/auto_bisect/api.py |
| @@ -39,12 +39,14 @@ class AutoBisectApi(recipe_api.RecipeApi): |
| self.override_poll_interval = None |
| self.bot_db = None |
| # Repo for triggering build jobs. |
| - self.svn_repo_url = 'svn://svn.chromium.org/chrome-try/try-perf' |
| + self.svn_repo_url = 'svn://svn.chromium.org/chrome-try/try-perf' |
| # The variable below are set and used for the internal bisects. |
| self.buildurl_gs_prefix = None |
| self.internal_bisect = False |
| self.builder_bot = None |
| self.full_deploy_script = None |
| + self.device_to_test = None |
| + self.device_tested = [] |
|
RobertoCN
2016/06/21 22:47:01
Nit: devices_tested
Ziqi Xiong
2016/06/22 17:38:22
Done.
|
| def perform_bisect(self, **flags): |
| return local_bisect.perform_bisect(self, **flags) |
| @@ -154,7 +156,7 @@ class AutoBisectApi(recipe_api.RecipeApi): |
| except self.m.step.StepFailure: # pragma: no cover |
| self.surface_result('BAD_REV') |
| raise |
| - |
| + |
| def run_bisect_script(self, **kwargs): |
| """Executes src/tools/run-perf-bisect-regression.py to perform bisection.""" |
| @@ -322,7 +324,7 @@ class AutoBisectApi(recipe_api.RecipeApi): |
| '-v', |
| '--blacklist-file', self.m.chromium_android.blacklist_file, |
| '--perfbot', |
| - '--release', |
| + '--release', |
| ] |
| if args: |
| full_deploy_flags += args |
| @@ -332,7 +334,7 @@ class AutoBisectApi(recipe_api.RecipeApi): |
| full_deploy_flags, |
| infra_step=True, |
| env=self.m.chromium.get_env()) |
|
RobertoCN
2016/06/21 22:47:01
Thanks for fixing this.
Ziqi Xiong
2016/06/22 17:38:22
Done.
|
| - |
| + |
| def start_try_job(self, api, update_step=None, bot_db=None, **kwargs): |
| """Starts a recipe bisect job, perf test run, or legacy bisect run. |