Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 2045013005: [ic] always print short for of keys with --trace-print (Closed)

Created:
4 years, 6 months ago by Camillo Bruni
Modified:
4 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[--trace-ic] always print short form of keys BUG= NOTRY=Y Committed: https://crrev.com/1ed327977d72745c7e189603441fc4d32ab221e1 Cr-Commit-Position: refs/heads/master@{#36858}

Patch Set 1 #

Patch Set 2 : rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M src/ic/ic.cc View 1 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
Camillo Bruni
PTAL (short CL)
4 years, 6 months ago (2016-06-08 13:52:38 UTC) #2
Jakob Kummerow
s/[ic]/[--trace-ic]/, s/short for/short form/, and then LGTM ;-)
4 years, 6 months ago (2016-06-08 13:59:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045013005/1
4 years, 6 months ago (2016-06-08 14:09:28 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/2846)
4 years, 6 months ago (2016-06-08 14:12:18 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045013005/20001
4 years, 6 months ago (2016-06-09 11:46:15 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-09 12:35:49 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 12:38:37 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1ed327977d72745c7e189603441fc4d32ab221e1
Cr-Commit-Position: refs/heads/master@{#36858}

Powered by Google App Engine
This is Rietveld 408576698