Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
4 years, 6 months ago by Camillo Bruni Modified:
4 years, 6 months ago Reviewers:
Jakob Kummerow CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[--trace-ic] always print short form of keys
BUG=
NOTRY=Y
Committed: https://crrev.com/1ed327977d72745c7e189603441fc4d32ab221e1
Cr-Commit-Position: refs/heads/master@{#36858}
Patch Set 1 #Patch Set 2 : rebasing #
Created: 4 years, 6 months ago
Messages
Total messages: 15 (8 generated)
cbruni@chromium.org changed reviewers: + jkummerow@chromium.org
PTAL (short CL)
Description was changed from ========== [ic] always print short for of keys with --trace-print BUG= ========== to ========== [--trace-ic] always print short form of keys BUG= ==========
s/[ic]/[--trace-ic]/, s/short for/short form/, and then LGTM ;-)
Description was changed from ========== [--trace-ic] always print short form of keys BUG= ========== to ========== [--trace-ic] always print short form of keys BUG= NOTRY=Y ==========
The CQ bit was checked by cbruni@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045013005/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_mac_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/2846)
The CQ bit was checked by cbruni@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from jkummerow@chromium.org Link to the patchset: https://codereview.chromium.org/2045013005/#ps20001 (title: "rebasing")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045013005/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [--trace-ic] always print short form of keys BUG= NOTRY=Y ========== to ========== [--trace-ic] always print short form of keys BUG= NOTRY=Y Committed: https://crrev.com/1ed327977d72745c7e189603441fc4d32ab221e1 Cr-Commit-Position: refs/heads/master@{#36858} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/1ed327977d72745c7e189603441fc4d32ab221e1 Cr-Commit-Position: refs/heads/master@{#36858} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
