Fix GetPageIndex() for dynamic XFA documents.

Fix GetPageIndex() for dynamic XFA documents.

BUG=614211
Committed: https://pdfium.googlesource.com/pdfium/+/d3be111cac2bb20e1917b3fae2102e742bb7efdb

[Lei Zhang, 2016-06-08 07:33:56]

thestig@chromium.org changed reviewers:
+ dsinclair@chromium.org

[Lei Zhang, 2016-06-08 07:33:57]

https://codereview.chromium.org/2045013004/diff/1/fpdfsdk/fsdk_mgr.cpp
File fpdfsdk/fsdk_mgr.cpp (left):

https://codereview.chromium.org/2045013004/diff/1/fpdfsdk/fsdk_mgr.cpp#oldcod...
fpdfsdk/fsdk_mgr.cpp:994: CPDF_Dictionary* pDic =
m_page->GetPDFPage()->m_pFormDict;
GetPDFPage() is only valid for non-dynamic docs.

https://codereview.chromium.org/2045013004/diff/1/fpdfsdk/fsdk_mgr.cpp
File fpdfsdk/fsdk_mgr.cpp (right):

https://codereview.chromium.org/2045013004/diff/1/fpdfsdk/fsdk_mgr.cpp#newcod...
fpdfsdk/fsdk_mgr.cpp:1041: CPDF_Page* pPage = m_page->GetPDFPage();
Maybe we need CPDFPageFromUnderlyingPageType() ? For another CL.

https://codereview.chromium.org/2045013004/diff/1/fpdfsdk/include/fsdk_mgr.h
File fpdfsdk/include/fsdk_mgr.h (left):

https://codereview.chromium.org/2045013004/diff/1/fpdfsdk/include/fsdk_mgr.h#...
fpdfsdk/include/fsdk_mgr.h:37: FPDF_WIDESTRING AsFPDFWideString(CFX_ByteString*
bsUTF16LE);
Never used outside.

https://codereview.chromium.org/2045013004/diff/1/fpdfsdk/include/fsdk_mgr.h#...
fpdfsdk/include/fsdk_mgr.h:619: void
PageView_OnHighlightFormFields(CFX_RenderDevice* pDevice,
No impl.

[Lei Zhang, 2016-06-08 07:44:37]

Testing-wise, we need to make a dynamic XFA and static XFA version of
testing/resources/javascript/document_props.in, but I have no idea how much work
that is.

[dsinclair, 2016-06-08 13:11:02]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-06-08 13:11:03]

lgtm

[commit-bot: I haz the power, 2016-06-08 13:11:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2045013004/20001

[commit-bot: I haz the power, 2016-06-08 13:11:23]

Description was changed from

==========
Fix GetPageIndex() for dynamic XFA documents.

BUG=614211
==========

to

==========
Fix GetPageIndex() for dynamic XFA documents.

BUG=614211

Committed:
https://pdfium.googlesource.com/pdfium/+/d3be111cac2bb20e1917b3fae2102e742bb7...
==========

[commit-bot: I haz the power, 2016-06-08 13:11:24]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/d3be111cac2bb20e1917b3fae2102e742bb7...