Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: chrome/test/data/webui/settings/site_list_tests.js

Issue 2044963003: Site Settings Desktop: Change how adding site exceptions work. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address feedback Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/settings/site_settings/site_settings_category.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/settings/site_list_tests.js
diff --git a/chrome/test/data/webui/settings/site_list_tests.js b/chrome/test/data/webui/settings/site_list_tests.js
index 79fd14880e979e9580a2ace8983e77de540179c5..018a05c506190d086378d5342cce8061157a6717 100644
--- a/chrome/test/data/webui/settings/site_list_tests.js
+++ b/chrome/test/data/webui/settings/site_list_tests.js
@@ -320,14 +320,12 @@ cr.define('site_list', function() {
settings.PermissionValues.ALLOW, testElement.categorySubtype);
assertEquals('Allow - 0', testElement.$.header.innerText.trim());
- // Site list should not show, no matter what category default is set
- // to.
- assertTrue(testElement.$.category.hidden);
+ assertFalse(testElement.$.category.hidden);
browserProxy.resetResolver('getExceptionList');
testElement.categoryEnabled = false;
return browserProxy.whenCalled('getExceptionList').then(
function(contentType) {
- assertTrue(testElement.$.category.hidden);
+ assertFalse(testElement.$.category.hidden);
assertEquals('Exceptions - 0',
testElement.$.header.innerText.trim());
});
@@ -477,7 +475,7 @@ cr.define('site_list', function() {
});
});
- test('Block list hidden when empty', function() {
+ test('Block list not hidden when empty', function() {
// Prefs: One item in Allow list, nothing in Block list.
setupLocationCategory(
settings.PermissionValues.BLOCK, prefsOneEnabled);
@@ -486,11 +484,11 @@ cr.define('site_list', function() {
assertEquals(
settings.ContentSettingsTypes.GEOLOCATION, contentType);
- assertTrue(testElement.$.category.hidden);
+ assertFalse(testElement.$.category.hidden);
});
});
- test('Allow list hidden when empty', function() {
+ test('Allow list not hidden when empty', function() {
// Prefs: One item in Block list, nothing in Allow list.
setupLocationCategory(settings.PermissionValues.ALLOW,
prefsOneDisabled);
@@ -499,7 +497,7 @@ cr.define('site_list', function() {
assertEquals(
settings.ContentSettingsTypes.GEOLOCATION, contentType);
- assertTrue(testElement.$.category.hidden);
+ assertFalse(testElement.$.category.hidden);
});
});
« no previous file with comments | « chrome/browser/resources/settings/site_settings/site_settings_category.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698