Site Settings Desktop: Change how adding site exceptions work.

chrome/test/data/webui/settings/site_list_tests.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /** @fileoverview Suite of tests for site-list. */
 cr.define('site_list', function() {
   function registerTests() {
     suite('SiteList', function() {
       /**
        * A site list element created before each test.
@@ skipping 302 matching lines @@
           function(contentType) {
             assertEquals(
                 settings.ContentSettingsTypes.GEOLOCATION, contentType);
 
             assertEquals(0, testElement.sites.length);
 
             assertEquals(
                 settings.PermissionValues.ALLOW, testElement.categorySubtype);
             assertEquals('Allow - 0', testElement.$.header.innerText.trim());
 
-            // Site list should not show, no matter what category default is set
-            // to.
-            assertTrue(testElement.$.category.hidden);
+            assertFalse(testElement.$.category.hidden);
             browserProxy.resetResolver('getExceptionList');
             testElement.categoryEnabled = false;
             return browserProxy.whenCalled('getExceptionList').then(
               function(contentType) {
-                assertTrue(testElement.$.category.hidden);
+                assertFalse(testElement.$.category.hidden);
                 assertEquals('Exceptions - 0',
                     testElement.$.header.innerText.trim());
             });
           });
       });
 
       test('initial ALLOW state is correct', function() {
         setupLocationCategory(settings.PermissionValues.ALLOW, prefs);
         return browserProxy.whenCalled('getExceptionList').then(
           function(contentType) {
@@ skipping 129 matching lines @@
             assertEquals(
                 settings.ContentSettingsTypes.GEOLOCATION, contentType);
 
             assertFalse(testElement.$.category.hidden);
             assertTrue(testElement.$.category.opened);
         }).then(function() {
             assertNotEquals(0, testElement.$.listContainer.offsetHeight);
         });
       });
 
-      test('Block list hidden when empty', function() {
+      test('Block list not hidden when empty', function() {
         // Prefs: One item in Allow list, nothing in Block list.
         setupLocationCategory(
             settings.PermissionValues.BLOCK, prefsOneEnabled);
         return browserProxy.whenCalled('getExceptionList').then(
           function(contentType) {
             assertEquals(
                 settings.ContentSettingsTypes.GEOLOCATION, contentType);
 
-            assertTrue(testElement.$.category.hidden);
+            assertFalse(testElement.$.category.hidden);
         });
       });
 
-      test('Allow list hidden when empty', function() {
+      test('Allow list not hidden when empty', function() {
         // Prefs: One item in Block list, nothing in Allow list.
         setupLocationCategory(settings.PermissionValues.ALLOW,
                               prefsOneDisabled);
         return browserProxy.whenCalled('getExceptionList').then(
           function(contentType) {
             assertEquals(
                 settings.ContentSettingsTypes.GEOLOCATION, contentType);
 
-            assertTrue(testElement.$.category.hidden);
+            assertFalse(testElement.$.category.hidden);
         });
       });
 
       test('All sites category', function() {
         // Prefs: Multiple and overlapping sites.
         setupAllSitesCategory(prefsVarious);
 
         return browserProxy.whenCalled('getExceptionList').then(
           function(contentType) {
             // Use resolver to ensure asserts bubble up to the framework with
@@ skipping 82 matching lines @@
           function(contentType) {
             // No further checks needed. If this fails, it will hang the test.
         });
       });
     });
   }
   return {
     registerTests: registerTests,
   };
 });