Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2044933002: Add codereview.settings and README.chromium to gRPC (Closed)

Created:
4 years, 6 months ago by agable
Modified:
4 years, 6 months ago
Reviewers:
iannucci1, xyzzyz, iannucci
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/external/github.com/grpc/grpc@chromium
Target Ref:
refs/heads/chromium
Visibility:
Public.

Description

Add codereview.settings and README.chromium to gRPC These are landing on the 'refs/heads/chromium' branch; the 'master' branch is a perfect mirror of upstream. BUG=617282 R=iannucci@google.com Committed: https://chromium.googlesource.com/external/github.com/grpc/grpc/+/9bc59727276bf0b1e62c9b25bff4b5e515ff6c58

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
A README.chromium View 1 chunk +8 lines, -0 lines 0 comments Download
A codereview.settings View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
agable
This CL adds the base files you need to conduct code review. After I get ...
4 years, 6 months ago (2016-06-07 17:29:57 UTC) #2
iannucci1
rs lgtm
4 years, 6 months ago (2016-06-07 17:31:25 UTC) #4
agable
4 years, 6 months ago (2016-06-07 17:31:52 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9bc59727276bf0b1e62c9b25bff4b5e515ff6c58 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698