src/objects.cc - Issue 204493002: Fix assert in Runtime_SetIsObserved.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 204493002: Fix assert in Runtime_SetIsObserved. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed comments by Rafael. Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 787b6d82b47145688e92447ff2e57f24473ff5d7..c63238f6c0dcc892343aed18c73696f917d1df72 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -5652,11 +5652,9 @@ Handle<Object> JSObject::Freeze(Handle<JSObject> object) {

void JSObject::SetObserved(Handle<JSObject> object) {

+ ASSERT(!object->map()->is_observed());

Isolate* isolate = object->GetIsolate();

- if (object->map()->is_observed())

- return;

LookupResult result(isolate);

object->map()->LookupTransition(*object,

isolate->heap()->observed_symbol(),

« no previous file with comments | « no previous file | src/runtime.cc » ('j') | no next file with comments »