Issue 204493002: Fix assert in Runtime_SetIsObserved.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 204493002: Fix assert in Runtime_SetIsObserved. (Closed)

Created:
6 years, 9 months ago by Michael Starzinger

Modified:
6 years, 8 months ago

Reviewers:
rafaelw

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -5 lines)			Patch
	M	src/objects.cc	View	1	1 chunk	+1 line, -3 lines	0 comments	Download
	M	src/runtime.cc	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

rafaelw

Thanks for fixing this, Michael. LGTM modulo: -Rather than putting the assert here, I'd prefer ...

6 years, 9 months ago (2014-03-19 16:29:48 UTC) #2

Michael Starzinger

Ooops, completely dropped this one on the floor. Addressed comments now. Landing.

6 years, 8 months ago (2014-04-02 14:35:04 UTC) #3

Michael Starzinger

6 years, 8 months ago (2014-04-02 14:47:43 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r20440 (presubmit successful).