chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm - Issue 2044923005: [Mac][Material Design] Fix strange Apps button highlight in dark themes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

Issue 2044923005: [Mac][Material Design] Fix strange Apps button highlight in dark themes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2743

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

index 5b86be96264a3ea68b2130bef5f229b0fab7bd86..9aa000dc9fef856ba2a6de4a25fd2c5eb35ea77e 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

@@ -1973,6 +1973,7 @@ CGFloat BookmarkRightMargin() {

menuController:contextMenuController_];

if (ui::MaterialDesignController::IsModeMaterial()) {

[cell setTag:kMaterialStandardButtonTypeWithLimitedClickFeedback];

+ [cell setHighlightsBy:NSNoCellMask];

} else {

[cell setTag:kStandardButtonTypeWithLimitedClickFeedback];

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »