Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2044923004:
Use monotonic time to record the touch event latency in Blink (Closed)
DescriptionUse monotonic time to record the touch input latency in Blink.
Since PlatformEvent uses monotonical time stamp, we should use monotonicallyIncreasingTime
instead of currentTime to record the touch event latency in Blink.
BUG=617984
Committed: https://crrev.com/c5707d4d2131cf90f2fe8c9887a1c95c83a12812
Cr-Commit-Position: refs/heads/master@{#398712}
Patch Set 1 #
Messages
Total messages: 18 (8 generated)
Description was changed from ========== monotonical BUG=617984 ========== to ========== Use monotonic time to record the touch input latency in Blink. Since PlatformEvent uses monotonical time stamp, we should use monotonicallyIncreasingTime instead of currentTime to record the touch event latency in Blink. BUG=617984 ==========
lanwei@chromium.org changed reviewers: + tdresser@chromium.org
lanwei@chromium.org changed reviewers: + dtapuska@chromium.org, majidvp@chromium.org
Description was changed from ========== Use monotonic time to record the touch input latency in Blink. Since PlatformEvent uses monotonical time stamp, we should use monotonicallyIncreasingTime instead of currentTime to record the touch event latency in Blink. BUG=617984 ========== to ========== Use monotonic time to record the touch input latency in Blink. Since PlatformEvent uses monotonical time stamp, we should use monotonicallyIncreasingTime instead of currentTime to record the touch event latency in Blink. BUG=617984 ==========
On 2016/06/07 22:41:55, lanwei wrote: Lgtm
LGTM
lanwei@chromium.org changed reviewers: + bokan@chromium.org
bokan@chromium.org: Please review changes in third_party/WebKit/Source/core/input/TouchEventManager.cpp Thank you!
lgtm
On 2016/06/08 14:50:42, bokan wrote: > lgtm May the 4th lgtm be with you! unrelated: We should just standardize on common constants for millisecondsPerSeconds in blink similar to base/time. Perhaps we should just use those.
On 2016/06/08 15:56:08, majidvp wrote: > On 2016/06/08 14:50:42, bokan wrote: > > lgtm > > May the 4th lgtm be with you! > > unrelated: We should just standardize on common constants for > millisecondsPerSeconds in blink similar to base/time. Perhaps we should just use > those. We cannot use Chromium class from namespace base inside Blink core. It is nice if we can have these constants in Blink.
The CQ bit was checked by lanwei@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044923004/1
Message was sent while issue was closed.
Description was changed from ========== Use monotonic time to record the touch input latency in Blink. Since PlatformEvent uses monotonical time stamp, we should use monotonicallyIncreasingTime instead of currentTime to record the touch event latency in Blink. BUG=617984 ========== to ========== Use monotonic time to record the touch input latency in Blink. Since PlatformEvent uses monotonical time stamp, we should use monotonicallyIncreasingTime instead of currentTime to record the touch event latency in Blink. BUG=617984 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Use monotonic time to record the touch input latency in Blink. Since PlatformEvent uses monotonical time stamp, we should use monotonicallyIncreasingTime instead of currentTime to record the touch event latency in Blink. BUG=617984 ========== to ========== Use monotonic time to record the touch input latency in Blink. Since PlatformEvent uses monotonical time stamp, we should use monotonicallyIncreasingTime instead of currentTime to record the touch event latency in Blink. BUG=617984 Committed: https://crrev.com/c5707d4d2131cf90f2fe8c9887a1c95c83a12812 Cr-Commit-Position: refs/heads/master@{#398712} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/c5707d4d2131cf90f2fe8c9887a1c95c83a12812 Cr-Commit-Position: refs/heads/master@{#398712} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
