Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2044893002:
Fix version format used on iOS by build/mac/tweak_info_plist.py. (Closed)
DescriptionFix version format used on iOS by build/mac/tweak_info_plist.py.
Chrome on iOS uses different format by default for the "CFBundleVersion"
and "CFBundleShortVersionString" Info.plist values.
Change _AddVersionKeys function to take as parameter a dictionary from
Info.plist keys to version format using @MAJOR@, @MINOR@, @BUILD@ and
@PATCH@ patterns to represent the different component of the version,
and pass a different dictionary depending on the platform.
Refactor how the version is extracted using the build/util/version.py
script (it was invoked twice, but the second invocation can be removed
as the output needs to be post-processed).
BUG=502295, 616750
Committed: https://crrev.com/8001eee13920c32ca685f6700bbe2db77eed8046
Cr-Commit-Position: refs/heads/master@{#398323}
Patch Set 1 #
Total comments: 6
Patch Set 2 : Remove debug "print" statements #Messages
Total messages: 16 (7 generated)
sdefresne@chromium.org changed reviewers: + olivierrobin@chromium.org, thomasvl@chromium.org
olivierrobin: can you review to ensure this now use the correct values on iOS? thomasvl: can you review as sole build/mac OWNERS available?
LGTM after you remove the print https://codereview.chromium.org/2044893002/diff/1/build/mac/tweak_info_plist.py File build/mac/tweak_info_plist.py (right): https://codereview.chromium.org/2044893002/diff/1/build/mac/tweak_info_plist.... build/mac/tweak_info_plist.py:92: print version_format, values, overrides des bugs ? https://codereview.chromium.org/2044893002/diff/1/build/mac/tweak_info_plist.... build/mac/tweak_info_plist.py:99: print 'result = %r.replace(\'@%%s@\' %% %r, %r)' % (result, key, value) ditto https://codereview.chromium.org/2044893002/diff/1/build/mac/tweak_info_plist.... build/mac/tweak_info_plist.py:101: print result ditto
Thank you for the review Olivier. https://codereview.chromium.org/2044893002/diff/1/build/mac/tweak_info_plist.py File build/mac/tweak_info_plist.py (right): https://codereview.chromium.org/2044893002/diff/1/build/mac/tweak_info_plist.... build/mac/tweak_info_plist.py:92: print version_format, values, overrides On 2016/06/07 14:51:24, Olivier Robin wrote: > des bugs ? Good catch. Done. https://codereview.chromium.org/2044893002/diff/1/build/mac/tweak_info_plist.... build/mac/tweak_info_plist.py:99: print 'result = %r.replace(\'@%%s@\' %% %r, %r)' % (result, key, value) On 2016/06/07 14:51:24, Olivier Robin wrote: > ditto Done. https://codereview.chromium.org/2044893002/diff/1/build/mac/tweak_info_plist.... build/mac/tweak_info_plist.py:101: print result On 2016/06/07 14:51:24, Olivier Robin wrote: > ditto Done.
Description was changed from ========== Fix version format used on iOS by build/mac/tweak_info_plist.py. Chrome on iOS uses different format by default for the "CFBundleVersion" and "CFBundleShortVersionString" Info.plist values. Change _AddVersionKeys function to take as parameter a dictionary from Info.plist keys to version format using @MAJOR@, @MINOR@, @BUILD@ and @PATCH@ patterns to represent the different component of the version, and pass a different dictionary depending on the platform. Refactor how the version is extracted using the build/util/version.py script (it was invoked twice, but the second invocation can be removed as the output needs to be post-processed). BUG=502295 ========== to ========== Fix version format used on iOS by build/mac/tweak_info_plist.py. Chrome on iOS uses different format by default for the "CFBundleVersion" and "CFBundleShortVersionString" Info.plist values. Change _AddVersionKeys function to take as parameter a dictionary from Info.plist keys to version format using @MAJOR@, @MINOR@, @BUILD@ and @PATCH@ patterns to represent the different component of the version, and pass a different dictionary depending on the platform. Refactor how the version is extracted using the build/util/version.py script (it was invoked twice, but the second invocation can be removed as the output needs to be post-processed). BUG=502295,616750 ==========
sdefresne@chromium.org changed reviewers: + carusom@google.com
+carusom: FYI
On 2016/06/07 15:44:59, sdefresne wrote: > +carusom: FYI tvl: This issue is breaking compile on the ios canary. Can you take a look as soon as you get a chance?
lgtm
The CQ bit was checked by carusom@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from olivierrobin@chromium.org Link to the patchset: https://codereview.chromium.org/2044893002/#ps20001 (title: "Remove debug "print" statements")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044893002/20001
Message was sent while issue was closed.
Description was changed from ========== Fix version format used on iOS by build/mac/tweak_info_plist.py. Chrome on iOS uses different format by default for the "CFBundleVersion" and "CFBundleShortVersionString" Info.plist values. Change _AddVersionKeys function to take as parameter a dictionary from Info.plist keys to version format using @MAJOR@, @MINOR@, @BUILD@ and @PATCH@ patterns to represent the different component of the version, and pass a different dictionary depending on the platform. Refactor how the version is extracted using the build/util/version.py script (it was invoked twice, but the second invocation can be removed as the output needs to be post-processed). BUG=502295,616750 ========== to ========== Fix version format used on iOS by build/mac/tweak_info_plist.py. Chrome on iOS uses different format by default for the "CFBundleVersion" and "CFBundleShortVersionString" Info.plist values. Change _AddVersionKeys function to take as parameter a dictionary from Info.plist keys to version format using @MAJOR@, @MINOR@, @BUILD@ and @PATCH@ patterns to represent the different component of the version, and pass a different dictionary depending on the platform. Refactor how the version is extracted using the build/util/version.py script (it was invoked twice, but the second invocation can be removed as the output needs to be post-processed). BUG=502295,616750 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Fix version format used on iOS by build/mac/tweak_info_plist.py. Chrome on iOS uses different format by default for the "CFBundleVersion" and "CFBundleShortVersionString" Info.plist values. Change _AddVersionKeys function to take as parameter a dictionary from Info.plist keys to version format using @MAJOR@, @MINOR@, @BUILD@ and @PATCH@ patterns to represent the different component of the version, and pass a different dictionary depending on the platform. Refactor how the version is extracted using the build/util/version.py script (it was invoked twice, but the second invocation can be removed as the output needs to be post-processed). BUG=502295,616750 ========== to ========== Fix version format used on iOS by build/mac/tweak_info_plist.py. Chrome on iOS uses different format by default for the "CFBundleVersion" and "CFBundleShortVersionString" Info.plist values. Change _AddVersionKeys function to take as parameter a dictionary from Info.plist keys to version format using @MAJOR@, @MINOR@, @BUILD@ and @PATCH@ patterns to represent the different component of the version, and pass a different dictionary depending on the platform. Refactor how the version is extracted using the build/util/version.py script (it was invoked twice, but the second invocation can be removed as the output needs to be post-processed). BUG=502295,616750 Committed: https://crrev.com/8001eee13920c32ca685f6700bbe2db77eed8046 Cr-Commit-Position: refs/heads/master@{#398323} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/8001eee13920c32ca685f6700bbe2db77eed8046 Cr-Commit-Position: refs/heads/master@{#398323} |
