src/wasm/module-decoder.cc - Issue 2044833002: [wasm] Dont compute global offsets if the module had errors (e.g. invalid memory type for global).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/wasm/module-decoder.cc

Issue 2044833002: [wasm] Dont compute global offsets if the module had errors (e.g. invalid memory type for global). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Index: src/wasm/module-decoder.cc

diff --git a/src/wasm/module-decoder.cc b/src/wasm/module-decoder.cc

index 1fb7da3473c8075ef6bf6e09d1c3a6fd8c17d641..48f59cefa82bdf1d293da3eb529d4244e7dc2485 100644

--- a/src/wasm/module-decoder.cc

+++ b/src/wasm/module-decoder.cc

@@ -384,7 +384,7 @@ class ModuleDecoder : public Decoder {

}

done:

- CalculateGlobalsOffsets(module);

+ if (ok()) CalculateGlobalsOffsets(module);

const WasmModule* finished_module = module;

ModuleResult result = toResult(finished_module);

if (FLAG_dump_wasm_module) {

« no previous file with comments | « no previous file | test/unittests/wasm/module-decoder-unittest.cc » ('j') | test/unittests/wasm/module-decoder-unittest.cc » ('J')