[wasm] Dont compute global offsets if the module had errors (e.g. invalid memory type for global).

[wasm] Dont compute global offsets if the module had errors (e.g. invalid memory type for global).

R=ahaas@chromium.org,bradnelson@chromium.org
BUG=chromium:617884
Committed: https://crrev.com/ce291bedd0bd4b32a37aa02e34416b62a8688b7e
Cr-Commit-Position: refs/heads/master@{#36779}

[ahaas, 2016-06-07 09:04:42]

lgtm

https://codereview.chromium.org/2044833002/diff/1/test/unittests/wasm/module-...
File test/unittests/wasm/module-decoder-unittest.cc (right):

https://codereview.chromium.org/2044833002/diff/1/test/unittests/wasm/module-...
test/unittests/wasm/module-decoder-unittest.cc:205: static const byte data[] = {
Could you add a comment which says why this data is invalid?

[titzer, 2016-06-07 09:11:08]

On 2016/06/07 09:04:42, ahaas wrote:
> lgtm
> 
>
https://codereview.chromium.org/2044833002/diff/1/test/unittests/wasm/module-...
> File test/unittests/wasm/module-decoder-unittest.cc (right):
> 
>
https://codereview.chromium.org/2044833002/diff/1/test/unittests/wasm/module-...
> test/unittests/wasm/module-decoder-unittest.cc:205: static const byte data[] =
{
> Could you add a comment which says why this data is invalid?

Done.

[titzer, 2016-06-07 09:11:12]

The CQ bit was checked by titzer@chromium.org

[titzer, 2016-06-07 09:11:12]

The patchset sent to the CQ was uploaded after l-g-t-m from ahaas@chromium.org
Link to the patchset: https://codereview.chromium.org/2044833002/#ps20001
(title: " ")

[commit-bot: I haz the power, 2016-06-07 09:11:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2044833002/20001

[commit-bot: I haz the power, 2016-06-07 09:35:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-07 09:38:53]

Description was changed from

==========
[wasm] Dont compute global offsets if the module had errors (e.g. invalid memory
type for global).

R=ahaas@chromium.org,bradnelson@chromium.org
BUG=chromium:617884
==========

to

==========
[wasm] Dont compute global offsets if the module had errors (e.g. invalid memory
type for global).

R=ahaas@chromium.org,bradnelson@chromium.org
BUG=chromium:617884

Committed: https://crrev.com/ce291bedd0bd4b32a37aa02e34416b62a8688b7e
Cr-Commit-Position: refs/heads/master@{#36779}
==========

[commit-bot: I haz the power, 2016-06-07 09:38:55]

Patchset 2 (id:??) landed as
https://crrev.com/ce291bedd0bd4b32a37aa02e34416b62a8688b7e
Cr-Commit-Position: refs/heads/master@{#36779}