Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 2044823002: Fix observable array access when formatting stack trace. (Closed)

Created:
4 years, 6 months ago by Yang
Modified:
4 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix observable array access when formatting stack trace. This is a fix intended to be merged. Ideally messages.js should be rewritten. R=bmeurer@chromium.org BUG=chromium:617527 Committed: https://crrev.com/85b8c2dc4aee1031ac02f9d7c02d5c1aa76bc2ba Cr-Commit-Position: refs/heads/master@{#36775}

Patch Set 1 #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -6 lines) Patch
M src/js/messages.js View 1 1 chunk +8 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Yang
4 years, 6 months ago (2016-06-07 07:20:09 UTC) #1
Benedikt Meurer
lgtm
4 years, 6 months ago (2016-06-07 07:30:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044823002/1
4 years, 6 months ago (2016-06-07 07:30:46 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_nodcheck_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/builds/2758) v8_linux_nodcheck_rel_ng_triggered on tryserver.v8 (JOB_FAILED, ...
4 years, 6 months ago (2016-06-07 07:45:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044823002/20001
4 years, 6 months ago (2016-06-07 08:13:29 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-07 08:36:51 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 08:37:56 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/85b8c2dc4aee1031ac02f9d7c02d5c1aa76bc2ba
Cr-Commit-Position: refs/heads/master@{#36775}

Powered by Google App Engine
This is Rietveld 408576698