Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(940)

Issue 2044813002: Revert of Fix event page process cleanup when running in --isolate-extensions mode. (patchset #6 id… (Closed)

Created:
4 years, 6 months ago by scottmg
Modified:
4 years, 6 months ago
Reviewers:
Devlin
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2761
Target Ref:
refs/pending/branch-heads/2761
Project:
chromium
Visibility:
Public.

Description

Revert of Fix event page process cleanup when running in --isolate-extensions mode. (patchset #6 id:100001 of https://codereview.chromium.org/2028873002/ ) Reason for revert: Speculative revert of this CL to check if it is the root cause of https://crbug.com/616989. Original issue's description: > Fix event page process cleanup when running in --isolate-extensions mode. > > With --isolate-extensions, navigations can start in one RenderFrameHost > and complete in another. This was not possible to happen with extensions > related RenderFrameHosts in the past, so the code wasn't able to handle > it. This CL refactors the OnNetworkRequest(Started|Stopped) to use the > navigation request id as the stable identifier instead of the associated > RenderFrameHost. > > BUG=612668 > > Committed: https://crrev.com/c25500369dd9a7f49d2b7d276556b2e22ba840c8 > Cr-Commit-Position: refs/heads/master@{#397328} TBR=rdevlin.cronin@chromium.org BUG=612668 Review-Url: https://codereview.chromium.org/2044643003 Cr-Commit-Position: refs/heads/master@{#398185} (cherry picked from commit 3cae185174cf799005ee4d4f6147e01fad45e354) Committed: https://chromium.googlesource.com/chromium/src/+/211f46e6aa65ae29bec721c32e8aadbf2d625e9c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -81 lines) Patch
M chrome/browser/extensions/lazy_background_page_apitest.cc View 3 chunks +2 lines, -38 lines 0 comments Download
D chrome/test/data/extensions/api_test/lazy_background_page/event_page_with_web_iframe/event_page.html View 1 chunk +0 lines, -5 lines 0 comments Download
D chrome/test/data/extensions/api_test/lazy_background_page/event_page_with_web_iframe/manifest.json View 1 chunk +0 lines, -12 lines 0 comments Download
M extensions/browser/process_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/process_manager.cc View 1 chunk +12 lines, -25 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
scottmg
4 years, 6 months ago (2016-06-07 05:17:42 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
211f46e6aa65ae29bec721c32e8aadbf2d625e9c.

Powered by Google App Engine
This is Rietveld 408576698