[regexp] disallow regexp property class shorthand syntax for single char.

[regexp] disallow regexp property class shorthand syntax for single char.

R=littledan@chromium.org
BUG=

Committed: https://crrev.com/4620e29428d05cab21fbe7fb3ba12f89f2b80dd5
Cr-Commit-Position: refs/heads/master@{#36778}

[Yang, 2016-06-07 05:28:03]

Please take a look.

[mathias, 2016-06-07 06:15:39]

mathias@qiwi.be changed reviewers:
+ mathias@qiwi.be

[mathias, 2016-06-07 06:15:39]

Non-reviewer LGTM.

For future reference, this has been discussed here:
https://github.com/mathiasbynens/ecma262/pull/1#discussion_r65919834

https://codereview.chromium.org/2044803003/diff/1/test/mjsunit/harmony/regexp...
File test/mjsunit/harmony/regexp-property-general-category.js (right):

https://codereview.chromium.org/2044803003/diff/1/test/mjsunit/harmony/regexp...
test/mjsunit/harmony/regexp-property-general-category.js:15:
assertThrows("/\\pL/u");
Maybe test `\P` as well?

[Yang, 2016-06-07 06:46:17]

On 2016/06/07 06:15:39, mathias wrote:
> Non-reviewer LGTM.
> 
> For future reference, this has been discussed here:
> https://github.com/mathiasbynens/ecma262/pull/1#discussion_r65919834
> 
>
https://codereview.chromium.org/2044803003/diff/1/test/mjsunit/harmony/regexp...
> File test/mjsunit/harmony/regexp-property-general-category.js (right):
> 
>
https://codereview.chromium.org/2044803003/diff/1/test/mjsunit/harmony/regexp...
> test/mjsunit/harmony/regexp-property-general-category.js:15:
> assertThrows("/\\pL/u");
> Maybe test `\P` as well?

Thanks for the review. I added a couple of tests like you suggested.

[Yang, 2016-06-07 06:47:50]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-07 06:47:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2044803003/20001

[commit-bot: I haz the power, 2016-06-07 07:01:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-07 07:01:56]

Dry run: Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_avx2_rel_ng_triggered on tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng_trig...)

[Dan Ehrenberg, 2016-06-07 08:40:31]

lgtm

[Yang, 2016-06-07 08:47:48]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2016-06-07 08:47:49]

The patchset sent to the CQ was uploaded after l-g-t-m from mathias@qiwi.be
Link to the patchset: https://codereview.chromium.org/2044803003/#ps40001
(title: "fix tests")

[commit-bot: I haz the power, 2016-06-07 08:47:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2044803003/40001

[commit-bot: I haz the power, 2016-06-07 09:11:38]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-07 09:14:26]

Description was changed from

==========
[regexp] disallow regexp property class shorthand syntax for single char.

R=littledan@chromium.org
BUG=
==========

to

==========
[regexp] disallow regexp property class shorthand syntax for single char.

R=littledan@chromium.org
BUG=

Committed: https://crrev.com/4620e29428d05cab21fbe7fb3ba12f89f2b80dd5
Cr-Commit-Position: refs/heads/master@{#36778}
==========

[commit-bot: I haz the power, 2016-06-07 09:14:27]

Patchset 3 (id:??) landed as
https://crrev.com/4620e29428d05cab21fbe7fb3ba12f89f2b80dd5
Cr-Commit-Position: refs/heads/master@{#36778}