Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Issue 2044803002: cc: Clear always_use_active_tree_opacity_effect_ids (Closed)

Created:
4 years, 6 months ago by jaydasika
Modified:
4 years, 6 months ago
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Clear always_use_active_tree_opacity_effect_ids When we rebuild property trees. BUG=617826 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/8013559b9c20153c8ed18f24179841025c6587f6 Cr-Commit-Position: refs/heads/master@{#398344}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M cc/layers/scrollbar_layer_unittest.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M cc/trees/property_tree_builder.cc View 1 chunk +2 lines, -0 lines 1 comment Download

Messages

Total messages: 18 (8 generated)
jaydasika
PTAL
4 years, 6 months ago (2016-06-07 04:15:10 UTC) #3
jaydasika
https://codereview.chromium.org/2044803002/diff/1/cc/trees/property_tree_builder.cc File cc/trees/property_tree_builder.cc (right): https://codereview.chromium.org/2044803002/diff/1/cc/trees/property_tree_builder.cc#newcode1234 cc/trees/property_tree_builder.cc:1234: .clear(); I think all clearing code should go into ...
4 years, 6 months ago (2016-06-07 04:17:35 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044803002/1
4 years, 6 months ago (2016-06-07 04:18:07 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/240057)
4 years, 6 months ago (2016-06-07 05:26:13 UTC) #8
ajuma
lgtm
4 years, 6 months ago (2016-06-07 14:01:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044803002/1
4 years, 6 months ago (2016-06-07 16:03:14 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/240337)
4 years, 6 months ago (2016-06-07 17:26:22 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044803002/1
4 years, 6 months ago (2016-06-07 17:55:23 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-07 18:18:51 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 18:20:07 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8013559b9c20153c8ed18f24179841025c6587f6
Cr-Commit-Position: refs/heads/master@{#398344}

Powered by Google App Engine
This is Rietveld 408576698