Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2044793002: Make GrShape use the original path when path effect fails. (Closed)

Created:
4 years, 6 months ago by bsalomon
Modified:
4 years, 6 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@segments
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make GrShape use the original path when path effect fails. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2044793002 Committed: https://skia.googlesource.com/skia/+/d67238421d661ea5dfd110a8028973801a7d42a1

Patch Set 1 #

Patch Set 2 : update tests #

Patch Set 3 : update commnet #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -5 lines) Patch
M src/gpu/GrShape.cpp View 1 chunk +10 lines, -5 lines 0 comments Download
M tests/GrShapeTest.cpp View 1 2 4 chunks +66 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 9 (5 generated)
bsalomon
This is to make GrShape match the canvas implementation, where we draw the original path ...
4 years, 6 months ago (2016-06-07 15:58:43 UTC) #3
egdaniel
lgtm
4 years, 6 months ago (2016-06-07 17:44:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2044793002/40001
4 years, 6 months ago (2016-06-07 19:06:42 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-07 19:20:19 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/d67238421d661ea5dfd110a8028973801a7d42a1

Powered by Google App Engine
This is Rietveld 408576698